From 9b68432624f4907861cf02c01954eda6f9e5cbe8 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Mon, 14 Sep 2009 12:27:29 -0300 Subject: [PATCH] commented out line that was preventing errors from propagating to the request errback --- scrapy/core/engine.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scrapy/core/engine.py b/scrapy/core/engine.py index 8b506ee6f..4bfc82616 100644 --- a/scrapy/core/engine.py +++ b/scrapy/core/engine.py @@ -161,7 +161,10 @@ class ExecutionEngine(object): def crawl(self, request, spider): schd = mustbe_deferred(self.schedule, request, spider) - schd.addErrback(log.err, "Unhandled error on engine.crawl()") + # FIXME: we can't log errors because we would be preventing them from + # propagating to the request errback. This should be fixed after the + # next core refactoring. + #schd.addErrback(log.err, "Error on engine.crawl()") schd.addBoth(self.scraper.enqueue_scrape, request, spider) schd.addErrback(log.err, "Unhandled error on engine.crawl()") schd.addBoth(lambda _: self.next_request(spider))