RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62 from darkrho/issue-58 

Avoid _disconnectedDeferred AttributeError exception in Twisted>=11.1.0
This commit is contained in:
Pablo Hoffman 2011-12-12 10:10:08 -08:00
parent 4fe42dc6fe 9c04945785
commit 9b84914736
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scrapy/core/downloader/webclient.py
View File

@ -98,6 +98,14 @@ class ScrapyHTTPClientFactory(HTTPClientFactory):
self.start_time = time()
self.deferred = defer.Deferred().addCallback(self._build_response, request)
# Fixes Twisted 11.1.0+ support as HTTPClientFactory is expected
# to have _disconnectedDeferred. See Twisted r32329.
# As Scrapy implements it's own logic to handle redirects is not
# needed to add the callback _waitForDisconnect.
# Specifically this avoids the AttributeError exception when
# clientConnectionFailed method is called.
self._disconnectedDeferred = defer.Deferred()
self._set_connection_attributes(request)
# set Host header based on url