From 9f335d379880a357f98be4d5645a3cb230227fd3 Mon Sep 17 00:00:00 2001 From: Adrian Chaves Date: Mon, 22 Jun 2026 12:24:07 +0200 Subject: [PATCH] Add a test to cover the default warnings from get_crawler() --- tests/test_crawler.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tests/test_crawler.py b/tests/test_crawler.py index f67f23778..462db656d 100644 --- a/tests/test_crawler.py +++ b/tests/test_crawler.py @@ -120,6 +120,24 @@ class TestCrawler(TestBaseCrawler): for warning in w ) + def test_get_crawler_prevent_warnings_false(self) -> None: + with warnings.catch_warnings(record=True) as w: + warnings.simplefilter("always") + get_crawler(prevent_warnings=False) + setting_names = { + "CONCURRENT_REQUESTS_PER_DOMAIN", + "DOWNLOAD_DELAY", + "ROBOTSTXT_OBEY", + } + warned_messages = [ + str(warning.message) + for warning in w + if issubclass(warning.category, ScrapyDeprecationWarning) + ] + assert all( + any(name in msg for msg in warned_messages) for name in setting_names + ) + def test_crawler_accepts_dict(self) -> None: crawler = get_crawler(DefaultSpider, {"foo": "bar"}) assert crawler.settings["foo"] == "bar"