RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

adjustments

This commit is contained in:
Felipe Boff Nunes 2023-04-06 14:23:19 -03:00
parent 0ffd1667ba
commit a0e2e36b52
2 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scrapy/extensions/feedexport.py
View File

@ -115,7 +115,6 @@ class BlockingFeedStorage:
@implementer(IFeedStorage)
class StdoutFeedStorage:
def __init__(self, uri, _stdout=None, *, feed_options=None):
if not _stdout:
_stdout = sys.stdout.buffer
@ -384,7 +383,6 @@ class FeedExporter:
return defer.DeferredList(deferred_list) if deferred_list else None
def _close_slot(self, slot, spider):
def get_file(slot_):
if isinstance(slot_.file, PostProcessingManager):
return slot_.file.file

22
tests/test_feedexport.py
View File

@ -1640,15 +1640,13 @@ class FeedExportTest(FeedExportTestBase):
@defer.inlineCallbacks
def test_storage_file_no_postprocessing(self):
@implementer(IFeedStorage)
class Storage:
def __init__(self, uri, *, feed_options=None):
pass
def open(self, spider):
Storage.open_file = tempfile.NamedTemporaryFile(prefix='feed-')
Storage.open_file = tempfile.NamedTemporaryFile(prefix="feed-")
return Storage.open_file
def store(self, file):
@ -1656,23 +1654,21 @@ class FeedExportTest(FeedExportTestBase):
file.close()
settings = {
'FEEDS': {self._random_temp_filename(): {'format': 'jsonlines'}},
'FEED_STORAGES': {'file': Storage},
"FEEDS": {self._random_temp_filename(): {"format": "jsonlines"}},
"FEED_STORAGES": {"file": Storage},
}
yield self.exported_no_data(settings)
self.assertIs(Storage.open_file, Storage.store_file)
@defer.inlineCallbacks
def test_storage_file_postprocessing(self):
@implementer(IFeedStorage)
class Storage:
def __init__(self, uri, *, feed_options=None):
pass
def open(self, spider):
Storage.open_file = tempfile.NamedTemporaryFile(prefix='feed-')
Storage.open_file = tempfile.NamedTemporaryFile(prefix="feed-")
return Storage.open_file
def store(self, file):
@ -1680,15 +1676,15 @@ class FeedExportTest(FeedExportTestBase):
file.close()
settings = {
'FEEDS': {
"FEEDS": {
self._random_temp_filename(): {
'format': 'jsonlines',
'postprocessing': [
'scrapy.extensions.postprocessing.GzipPlugin',
"format": "jsonlines",
"postprocessing": [
"scrapy.extensions.postprocessing.GzipPlugin",
],
},
},
'FEED_STORAGES': {'file': Storage},
"FEED_STORAGES": {"file": Storage},
}
yield self.exported_no_data(settings)
self.assertIs(Storage.open_file, Storage.store_file)