From fe5ef0a80a0008788e35c5b9d3c016e40ddf610f Mon Sep 17 00:00:00 2001 From: Aryan <1111aryantiwari@gmail.com> Date: Sun, 1 Oct 2023 11:47:51 +0530 Subject: [PATCH 1/3] Fixed the dont_merge_cookies example in docs --- docs/topics/request-response.rst | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst index 41df51589..8f204fb13 100644 --- a/docs/topics/request-response.rst +++ b/docs/topics/request-response.rst @@ -115,21 +115,18 @@ Request objects cookies for that domain and will be sent again in future requests. That's the typical behaviour of any regular web browser. - To create a request that does not send stored cookies and does not - store received cookies, set the ``dont_merge_cookies`` key to ``True`` - in :attr:`request.meta `. - - Example of a request that sends manually-defined cookies and ignores - cookie storage: + Example of a request that sends manually-defined cookies: .. code-block:: python Request( url="http://www.example.com", cookies={"currency": "USD", "country": "UY"}, - meta={"dont_merge_cookies": True}, ) + It is recommended not to set the ``dont_merge_cookies`` key to ``True`` + in :attr:`request.meta ` as it causes custom cookies to be ignored. + For more info see :ref:`cookies-mw`. .. caution:: Cookies set via the ``Cookie`` header are not considered by the From e146c3a2fc9059101f27112fc5e797f89e642fb5 Mon Sep 17 00:00:00 2001 From: Aryan <1111aryantiwari@gmail.com> Date: Mon, 2 Oct 2023 15:36:29 +0530 Subject: [PATCH 2/3] removed the entire example for dont_merge_cookies --- docs/topics/request-response.rst | 9 --------- 1 file changed, 9 deletions(-) diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst index 8f204fb13..d02af2a10 100644 --- a/docs/topics/request-response.rst +++ b/docs/topics/request-response.rst @@ -115,15 +115,6 @@ Request objects cookies for that domain and will be sent again in future requests. That's the typical behaviour of any regular web browser. - Example of a request that sends manually-defined cookies: - - .. code-block:: python - - Request( - url="http://www.example.com", - cookies={"currency": "USD", "country": "UY"}, - ) - It is recommended not to set the ``dont_merge_cookies`` key to ``True`` in :attr:`request.meta ` as it causes custom cookies to be ignored. From 42adbb21043f75bec5f513eb3b7ed86c988f7562 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Mon, 2 Oct 2023 14:43:30 +0200 Subject: [PATCH 3/3] Update docs/topics/request-response.rst --- docs/topics/request-response.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst index d02af2a10..adf3d0f4a 100644 --- a/docs/topics/request-response.rst +++ b/docs/topics/request-response.rst @@ -115,8 +115,9 @@ Request objects cookies for that domain and will be sent again in future requests. That's the typical behaviour of any regular web browser. - It is recommended not to set the ``dont_merge_cookies`` key to ``True`` - in :attr:`request.meta ` as it causes custom cookies to be ignored. + Note that setting the :reqmeta:`dont_merge_cookies` key to ``True`` in + :attr:`request.meta ` causes custom cookies to be + ignored. For more info see :ref:`cookies-mw`.