From aafb31d6fb86cb05ae1945685adbb615566068c4 Mon Sep 17 00:00:00 2001 From: Jakob de Maeyer Date: Mon, 9 Nov 2015 16:26:55 +0100 Subject: [PATCH] Revert "Move stats & log init into crawl()" This reverts commit 2c68c95cadbf45e11657b00058ff29921c27bffa. --- scrapy/crawler.py | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/scrapy/crawler.py b/scrapy/crawler.py index 10147524d..d121e90a5 100644 --- a/scrapy/crawler.py +++ b/scrapy/crawler.py @@ -31,6 +31,17 @@ class Crawler(object): self.settings = settings.copy() self.signals = SignalManager(self) + self.stats = load_object(self.settings['STATS_CLASS'])(self) + + handler = LogCounterHandler(self, level=settings.get('LOG_LEVEL')) + logging.root.addHandler(handler) + # lambda is assigned to Crawler attribute because this way it is not + # garbage collected after leaving __init__ scope + self.__remove_handler = lambda: logging.root.removeHandler(handler) + self.signals.connect(self.__remove_handler, signals.engine_stopped) + + lf_cls = load_object(self.settings['LOG_FORMATTER']) + self.logformatter = lf_cls.from_crawler(self) self.crawling = False self.spider = None @@ -63,20 +74,6 @@ class Crawler(object): self.spider = self._create_spider(*args, **kwargs) self.spider.update_settings(self.settings) self.settings.freeze() - - self.stats = load_object(self.settings['STATS_CLASS'])(self) - - handler = LogCounterHandler(self, - level=self.settings.get('LOG_LEVEL')) - logging.root.addHandler(handler) - # lambda is assigned to Crawler attribute because this way it is not - # garbage collected after leaving __init__ scope - self.__remove_handler = lambda: logging.root.removeHandler(handler) - self.signals.connect(self.__remove_handler, signals.engine_stopped) - - lf_cls = load_object(self.settings['LOG_FORMATTER']) - self.logformatter = lf_cls.from_crawler(self) - self.extensions = ExtensionManager.from_crawler(self) self.engine = self._create_engine()