RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make certain args of ScrapyAgent and TunnelingAgent required (#6349)

This commit is contained in:
Sanchay Kumar 2024-05-10 15:13:49 +05:30 committed by GitHub
parent 10a843ac1d
commit ae7bb849f5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scrapy/core/downloader/handlers/http11.py
View File

@ -239,15 +239,14 @@ class TunnelingAgent(Agent):
def __init__(
self,
*,
reactor: ReactorBase,
proxyConf: Tuple[str, int, Optional[bytes]],
contextFactory: Optional[IPolicyForHTTPS] = None,
contextFactory: IPolicyForHTTPS,
connectTimeout: Optional[float] = None,
bindAddress: Optional[bytes] = None,
pool: Optional[HTTPConnectionPool] = None,
):
# TODO make this arg required instead
assert contextFactory is not None
super().__init__(reactor, contextFactory, connectTimeout, bindAddress, pool)
self._proxyConf: Tuple[str, int, Optional[bytes]] = proxyConf
self._contextFactory: IPolicyForHTTPS = contextFactory
@ -335,18 +334,16 @@ class ScrapyAgent:
def __init__(
self,
contextFactory: Optional[IPolicyForHTTPS] = None,
*,
contextFactory: IPolicyForHTTPS,
connectTimeout: float = 10,
bindAddress: Optional[bytes] = None,
pool: Optional[HTTPConnectionPool] = None,
maxsize: int = 0,
warnsize: int = 0,
fail_on_dataloss: bool = True,
crawler: Optional[Crawler] = None,
crawler: Crawler,
):
# TODO make these args required instead
assert contextFactory is not None
assert crawler is not None
self._contextFactory: IPolicyForHTTPS = contextFactory
self._connectTimeout: float = connectTimeout
self._bindAddress: Optional[bytes] = bindAddress