From b397f5e935c616b1d4887ef8654f185321d35731 Mon Sep 17 00:00:00 2001 From: Julia Medina Date: Sat, 24 May 2014 08:06:00 -0300 Subject: [PATCH] Update get_crawler method in utils/test.py with new Settings interface This early adaptation of the new Settings interface is needed for running tests --- scrapy/utils/test.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/scrapy/utils/test.py b/scrapy/utils/test.py index 8c1f7fe8a..e6376d519 100644 --- a/scrapy/utils/test.py +++ b/scrapy/utils/test.py @@ -22,20 +22,13 @@ def assert_aws_environ(): def get_crawler(settings_dict=None): """Return an unconfigured Crawler object. If settings_dict is given, it - will be used as the settings present in the settings module of the - CrawlerSettings. + will be used to populate the crawler settings with a project level + priority. """ from scrapy.crawler import Crawler - from scrapy.settings import CrawlerSettings + from scrapy.settings import Settings - class SettingsModuleMock(object): - pass - settings_module = SettingsModuleMock() - if settings_dict: - for k, v in settings_dict.items(): - setattr(settings_module, k, v) - settings = CrawlerSettings(settings_module) - return Crawler(settings) + return Crawler(Settings(settings_dict)) def get_pythonpath(): """Return a PYTHONPATH suitable to use in processes so that they find this