From f85c915872cf70bb87a05cecd6ef5a6534d2c4ed Mon Sep 17 00:00:00 2001 From: Joaquin Garmendia Cabrera Date: Sun, 23 Dec 2018 00:26:58 -0500 Subject: [PATCH 1/2] Update item-pipeline example --- docs/topics/item-pipeline.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/topics/item-pipeline.rst b/docs/topics/item-pipeline.rst index 38265b474..1c2c51e05 100644 --- a/docs/topics/item-pipeline.rst +++ b/docs/topics/item-pipeline.rst @@ -87,8 +87,8 @@ contain a price:: vat_factor = 1.15 def process_item(self, item, spider): - if item['price']: - if item['price_excludes_vat']: + if 'price' in item and item['price']: + if 'price_excludes_vat' in item and item['price_excludes_vat']: item['price'] = item['price'] * self.vat_factor return item else: From e1f8b55ba0a132ed28c71661e2df3c5bc27feb75 Mon Sep 17 00:00:00 2001 From: Joaquin Garmendia Cabrera Date: Fri, 28 Dec 2018 16:53:12 -0500 Subject: [PATCH 2/2] Improve syntax for readability --- docs/topics/item-pipeline.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/topics/item-pipeline.rst b/docs/topics/item-pipeline.rst index 1c2c51e05..fae18200a 100644 --- a/docs/topics/item-pipeline.rst +++ b/docs/topics/item-pipeline.rst @@ -87,8 +87,8 @@ contain a price:: vat_factor = 1.15 def process_item(self, item, spider): - if 'price' in item and item['price']: - if 'price_excludes_vat' in item and item['price_excludes_vat']: + if item.get('price'): + if item.get('price_excludes_vat'): item['price'] = item['price'] * self.vat_factor return item else: