From b6707ce3bf6fa1971952b95b443a71d74fa7fa80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Sat, 15 Mar 2025 20:58:16 +0100 Subject: [PATCH] Address typing issues --- scrapy/core/engine.py | 2 ++ tests/test_engine_loop.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/scrapy/core/engine.py b/scrapy/core/engine.py index 21b9fe939..af4df161f 100644 --- a/scrapy/core/engine.py +++ b/scrapy/core/engine.py @@ -250,6 +250,7 @@ class ExecutionEngine: ) def _scheduler_has_pending_requests(self) -> bool: + assert self._slot is not None # typing try: return self._slot.scheduler.has_pending_requests() except Exception as exception: @@ -411,6 +412,7 @@ class ExecutionEngine: self._slot.nextcall.schedule() # type: ignore[union-attr] def _schedule_request(self, request: Request, spider: Spider) -> None: + assert self._slot is not None # typing request_scheduled_result = self.signals.send_catch_log( signals.request_scheduled, request=request, diff --git a/tests/test_engine_loop.py b/tests/test_engine_loop.py index 15792bc2b..0e3c11a68 100644 --- a/tests/test_engine_loop.py +++ b/tests/test_engine_loop.py @@ -19,7 +19,7 @@ from .mockserver import MockServer def sleep(seconds: float = ExecutionEngine._MIN_BACK_IN_SECONDS): from twisted.internet import reactor - deferred = Deferred() + deferred: Deferred[None] = Deferred() reactor.callLater(seconds, deferred.callback, None) return maybe_deferred_to_future(deferred)