RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor #3 Moved tests to FormRequestTest

This commit is contained in:
noon 2024-02-21 02:35:45 +01:00
parent e2a0c85f11
commit bc036542a8
1 changed files with 56 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
tests/test_http_request.py
View File

@ -1426,6 +1426,62 @@ class FormRequestTest(RequestTest):
r = self.request_class.from_response(response)
self.assertEqual(r.method, expected)
def test_form_response_with_invalid_formdata_type_error(self):
"""Test that a ValueError is raised for non-iterable and non-dict formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=123)
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_form_response_with_custom_invalid_formdata_value_error(self):
"""Test that a ValueError is raised for fault-inducing iterable formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
class CustomFormdata:
def __iter__(self):
raise ValueError("Custom iteration error for testing")
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=CustomFormdata())
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_get_form_with_xpath_no_form_parent(self):
"""Test that _get_from raised a ValueError when an XPath selects an element
not nested within a <form> and no <form> parent is found"""
response = _buildresponse(
"""<html><body>
<div id="outside-form">
<p>This paragraph is not inside a form.</p>
</div>
<form action="/submit" method="post">
<input type="text" name="inside-form" value="">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formxpath='//div[@id="outside-form"]/p')
self.assertIn("No <form> element found with", str(context.exception))
def _buildresponse(body, **kwargs):
kwargs.setdefault("body", body)
@ -1642,62 +1698,6 @@ class JsonRequestTest(RequestTest):
self.assertEqual(kwargs["ensure_ascii"], True)
self.assertEqual(kwargs["allow_nan"], True)
def test_form_response_with_invalid_formdata_type_error(self):
"""Test that a ValueError is raised for non-iterable and non-dict formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=123)
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_form_response_with_custom_invalid_formdata_value_error(self):
"""Test that a ValueError is raised for fault-inducing iterable formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
class CustomFormdata:
def __iter__(self):
raise ValueError("Custom iteration error for testing")
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=CustomFormdata())
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_get_form_with_xpath_no_form_parent(self):
"""Test that _get_from raised a ValueError when an XPath selects an element
not nested within a <form> and no <form> parent is found"""
response = _buildresponse(
"""<html><body>
<div id="outside-form">
<p>This paragraph is not inside a form.</p>
</div>
<form action="/submit" method="post">
<input type="text" name="inside-form" value="">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formxpath='//div[@id="outside-form"]/p')
self.assertIn("No <form> element found with", str(context.exception))
def tearDown(self):
warnings.resetwarnings()
super().tearDown()