RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTP/2: do not make conn_lost_deferred optional

This commit is contained in:
Adrián Chaves 2021-02-23 06:42:28 +01:00
parent 7605f19ec4
commit bd29f32dee
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scrapy/core/http2/protocol.py
View File

@ -70,7 +70,7 @@ class MethodNotAllowed405(H2Error):
class H2ClientProtocol(Protocol, TimeoutMixin):
IDLE_TIMEOUT = 240
def __init__(self, uri: URI, settings: Settings, conn_lost_deferred: Optional[Deferred] = None) -> None:
def __init__(self, uri: URI, settings: Settings, conn_lost_deferred: Deferred) -> None:
"""
Arguments:
uri -- URI of the base url to which HTTP/2 Connection will be made.
@ -308,8 +308,7 @@ class H2ClientProtocol(Protocol, TimeoutMixin):
if not reason.check(connectionDone):
self._conn_lost_errors.append(reason)
if self._conn_lost_deferred:
self._conn_lost_deferred.callback(self._conn_lost_errors)
self._conn_lost_deferred.callback(self._conn_lost_errors)
for stream in self.streams.values():
if stream.metadata['request_sent']:
@ -407,7 +406,7 @@ class H2ClientProtocol(Protocol, TimeoutMixin):
@implementer(IProtocolNegotiationFactory)
class H2ClientFactory(Factory):
def __init__(self, uri: URI, settings: Settings, conn_lost_deferred: Optional[Deferred] = None) -> None:
def __init__(self, uri: URI, settings: Settings, conn_lost_deferred: Deferred) -> None:
self.uri = uri
self.settings = settings
self.conn_lost_deferred = conn_lost_deferred