Merge pull request #2411 from redapple/remove-chunked-transfer-mw

[MRG+1] Remove ChunkedTransferMiddleware from default settings

docs/topics/downloader-middleware.rst

@@ -657,16 +657,6 @@ Default: ``True``
 Whether the Compression middleware will be enabled.
 
 
-ChunkedTransferMiddleware
--------------------------
-
-.. module:: scrapy.downloadermiddlewares.chunked
-   :synopsis: Chunked Transfer Middleware
-
-.. class:: ChunkedTransferMiddleware
-
-   This middleware adds support for `chunked transfer encoding`_
-
 HttpProxyMiddleware
 -------------------
 
@@ -970,4 +960,3 @@ The default encoding for proxy authentication on :class:`HttpProxyMiddleware`.
 
 .. _DBM: https://en.wikipedia.org/wiki/Dbm
 .. _anydbm: https://docs.python.org/2/library/anydbm.html
-.. _chunked transfer encoding: https://en.wikipedia.org/wiki/Chunked_transfer_encoding

docs/topics/settings.rst

@@ -468,7 +468,6 @@ Default::
         'scrapy.downloadermiddlewares.redirect.RedirectMiddleware': 600,
         'scrapy.downloadermiddlewares.cookies.CookiesMiddleware': 700,
         'scrapy.downloadermiddlewares.httpproxy.HttpProxyMiddleware': 750,
-        'scrapy.downloadermiddlewares.chunked.ChunkedTransferMiddleware': 830,
         'scrapy.downloadermiddlewares.stats.DownloaderStats': 850,
         'scrapy.downloadermiddlewares.httpcache.HttpCacheMiddleware': 900,
     }

scrapy/downloadermiddlewares/chunked.py

@@ -1,6 +1,14 @@
+import warnings
+
+from scrapy.exceptions import ScrapyDeprecationWarning
 from scrapy.utils.http import decode_chunked_transfer
 
 
+warnings.warn("Module `scrapy.downloadermiddlewares.chunked` is deprecated, "
+              "chunked transfers are supported by default.",
+              ScrapyDeprecationWarning, stacklevel=2)
+
+
 class ChunkedTransferMiddleware(object):
     """This middleware adds support for chunked transfer encoding, as
     documented in: http://en.wikipedia.org/wiki/Chunked_transfer_encoding

scrapy/settings/default_settings.py

@@ -102,7 +102,6 @@ DOWNLOADER_MIDDLEWARES_BASE = {
     'scrapy.downloadermiddlewares.redirect.RedirectMiddleware': 600,
     'scrapy.downloadermiddlewares.cookies.CookiesMiddleware': 700,
     'scrapy.downloadermiddlewares.httpproxy.HttpProxyMiddleware': 750,
-    'scrapy.downloadermiddlewares.chunked.ChunkedTransferMiddleware': 830,
     'scrapy.downloadermiddlewares.stats.DownloaderStats': 850,
     'scrapy.downloadermiddlewares.httpcache.HttpCacheMiddleware': 900,
     # Downloader side