From be0e33af92d1c84cdca6068e54fc736bb524342f Mon Sep 17 00:00:00 2001 From: Andrey Rakhmatullin Date: Wed, 13 Sep 2023 16:59:54 +0400 Subject: [PATCH] Don't rely on unhandled exception logging in the expected to fail scripts. --- .../asyncio_enabled_reactor_different_loop.py | 3 ++- .../reactor_default_twisted_reactor_select.py | 3 ++- .../reactor_select_subclass_twisted_reactor_select.py | 3 ++- .../twisted_reactor_custom_settings_conflict.py | 6 ++++-- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/CrawlerProcess/asyncio_enabled_reactor_different_loop.py b/tests/CrawlerProcess/asyncio_enabled_reactor_different_loop.py index 34ef00143..6fe88b011 100644 --- a/tests/CrawlerProcess/asyncio_enabled_reactor_different_loop.py +++ b/tests/CrawlerProcess/asyncio_enabled_reactor_different_loop.py @@ -24,5 +24,6 @@ process = CrawlerProcess( "ASYNCIO_EVENT_LOOP": "uvloop.Loop", } ) -process.crawl(NoRequestsSpider) +d = process.crawl(NoRequestsSpider) +d.addErrback(lambda failure: failure.printTraceback()) process.start() diff --git a/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py b/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py index 744b4ecb5..091e9d424 100644 --- a/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py +++ b/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py @@ -17,5 +17,6 @@ process = CrawlerProcess( } ) -process.crawl(NoRequestsSpider) +d = process.crawl(NoRequestsSpider) +d.addErrback(lambda failure: failure.printTraceback()) process.start() diff --git a/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py b/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py index a8f707841..5615e7a68 100644 --- a/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py +++ b/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py @@ -26,5 +26,6 @@ process = CrawlerProcess( } ) -process.crawl(NoRequestsSpider) +d = process.crawl(NoRequestsSpider) +d.addErrback(lambda failure: failure.printTraceback()) process.start() diff --git a/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py b/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py index 19cc08be6..7074a7389 100644 --- a/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py +++ b/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py @@ -17,6 +17,8 @@ class AsyncioReactorSpider(scrapy.Spider): process = CrawlerProcess() -process.crawl(SelectReactorSpider) -process.crawl(AsyncioReactorSpider) +d1 = process.crawl(SelectReactorSpider) +d1.addErrback(lambda failure: failure.printTraceback()) +d2 = process.crawl(AsyncioReactorSpider) +d2.addErrback(lambda failure: failure.printTraceback()) process.start()