From bef1fa967aeeddb34fc86a73d12a3f9ae90f81c0 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Tue, 20 Jan 2009 21:49:20 +0000 Subject: [PATCH] removed Request.append_callback() method (it was just an alias to Request.deferred.addCallback). refs #48 --HG-- extra : convert_revision : svn%3Ab85faa78-f9eb-468e-a121-7cced6da292c%40756 --- scrapy/trunk/scrapy/contrib/spiders/crawl.py | 2 +- scrapy/trunk/scrapy/http/request.py | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/scrapy/trunk/scrapy/contrib/spiders/crawl.py b/scrapy/trunk/scrapy/contrib/spiders/crawl.py index 25cf3d5fc..dc058976b 100644 --- a/scrapy/trunk/scrapy/contrib/spiders/crawl.py +++ b/scrapy/trunk/scrapy/contrib/spiders/crawl.py @@ -92,7 +92,7 @@ class CrawlSpider(BaseSpider): for link in links: r = Request(url=link.url) r.meta['link_text'] = link.text - r.append_callback(self._response_downloaded, rule.callback, cb_kwargs=rule.cb_kwargs, follow=rule.follow) + r.deferred.addCallback(self._response_downloaded, rule.callback, cb_kwargs=rule.cb_kwargs, follow=rule.follow) requests.append(r) return requests diff --git a/scrapy/trunk/scrapy/http/request.py b/scrapy/trunk/scrapy/http/request.py index 444ef0861..07d060e47 100644 --- a/scrapy/trunk/scrapy/http/request.py +++ b/scrapy/trunk/scrapy/http/request.py @@ -36,11 +36,6 @@ class Request(object): self.meta = {} if meta is None else dict(meta) self.cache = {} - def append_callback(self, callback, *args, **kwargs): - if isinstance(callback, defer.Deferred): - return chain_deferred(self.deferred, callback) - return self.deferred.addCallback(callback, *args, **kwargs) - def set_url(self, url): assert isinstance(url, basestring), \ 'Request url argument must be str or unicode, got %s:' % type(url).__name__