mirror of https://github.com/scrapy/scrapy.git
Remove obsolete DEPRECATED_SETTINGS (deprecated.py)
This commit is contained in:
parent
c57512fa66
commit
c2c6ea376c
|
|
@ -12,7 +12,6 @@ from scrapy.exceptions import UsageError
|
|||
from scrapy.utils.misc import walk_modules
|
||||
from scrapy.utils.project import inside_project, get_project_settings
|
||||
from scrapy.utils.python import garbage_collect
|
||||
from scrapy.settings.deprecated import check_deprecated_settings
|
||||
|
||||
|
||||
def _iter_command_classes(module_name):
|
||||
|
|
@ -118,7 +117,6 @@ def execute(argv=None, settings=None):
|
|||
pass
|
||||
else:
|
||||
settings['EDITOR'] = editor
|
||||
check_deprecated_settings(settings)
|
||||
|
||||
inproject = inside_project()
|
||||
cmds = _get_commands_dict(settings, inproject)
|
||||
|
|
|
|||
|
|
@ -1,23 +0,0 @@
|
|||
import warnings
|
||||
from scrapy.exceptions import ScrapyDeprecationWarning
|
||||
|
||||
DEPRECATED_SETTINGS = [
|
||||
('TRACK_REFS', 'no longer needed (trackref is always enabled)'),
|
||||
('RESPONSE_CLASSES', 'no longer supported'),
|
||||
('DEFAULT_RESPONSE_ENCODING', 'no longer supported'),
|
||||
('BOT_VERSION', 'no longer used (user agent defaults to Scrapy now)'),
|
||||
('ENCODING_ALIASES', 'no longer needed (encoding discovery uses w3lib now)'),
|
||||
('STATS_ENABLED', 'no longer supported (change STATS_CLASS instead)'),
|
||||
('SQLITE_DB', 'no longer supported'),
|
||||
('AUTOTHROTTLE_MIN_DOWNLOAD_DELAY', 'use DOWNLOAD_DELAY instead'),
|
||||
('AUTOTHROTTLE_MAX_CONCURRENCY', 'use CONCURRENT_REQUESTS_PER_DOMAIN instead'),
|
||||
]
|
||||
|
||||
|
||||
def check_deprecated_settings(settings):
|
||||
deprecated = [x for x in DEPRECATED_SETTINGS if settings[x[0]] is not None]
|
||||
if deprecated:
|
||||
msg = "You are using the following settings which are deprecated or obsolete"
|
||||
msg += " (ask scrapy-users@googlegroups.com for alternatives):"
|
||||
msg = msg + "\n " + "\n ".join("%s: %s" % x for x in deprecated)
|
||||
warnings.warn(msg, ScrapyDeprecationWarning)
|
||||
Loading…
Reference in New Issue