From 87202546e30ee7c7ce5c8d05cb6bf16a6b1a27d4 Mon Sep 17 00:00:00 2001 From: Julia Medina Date: Thu, 19 Mar 2015 03:03:16 -0300 Subject: [PATCH] Match default values in log.start This will avoid unexpected outputs when calling log.start explicitly. Main change is setting `logstdout` to False, since it's currently broken and generates issues like #451. --- scrapy/log.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scrapy/log.py b/scrapy/log.py index 5457bdb3e..02aca4dfa 100644 --- a/scrapy/log.py +++ b/scrapy/log.py @@ -12,6 +12,7 @@ from twisted.python import log import scrapy from scrapy.utils.python import unicode_to_str from scrapy.settings import overridden_settings +from scrapy.settings.default_settings import LOG_FILE, LOG_LEVEL, LOG_STDOUT, LOG_ENCODING # Logging levels DEBUG = logging.DEBUG @@ -111,7 +112,9 @@ def _get_log_level(level_name_or_id): else: raise ValueError("Unknown log level: %r" % level_name_or_id) -def start(logfile=None, loglevel='INFO', logstdout=True, logencoding='utf-8', crawler=None): +def start(logfile=LOG_FILE, loglevel=LOG_LEVEL, + logstdout=LOG_STDOUT, logencoding=LOG_ENCODING, + crawler=None): loglevel = _get_log_level(loglevel) file = open(logfile, 'a') if logfile else sys.stderr sflo = ScrapyFileLogObserver(file, loglevel, logencoding, crawler)