From d0edad4b0bd93ed34a680ddd6563387be7797128 Mon Sep 17 00:00:00 2001 From: Julia Medina Date: Thu, 31 Jul 2014 10:10:25 -0300 Subject: [PATCH] Drop support for ScrapyCommand.crawler property --- scrapy/command.py | 28 +--------------------------- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/scrapy/command.py b/scrapy/command.py index b2eb9cf8f..9ac013098 100644 --- a/scrapy/command.py +++ b/scrapy/command.py @@ -2,12 +2,11 @@ Base class for Scrapy commands """ import os -import warnings from optparse import OptionGroup from twisted.python import failure from scrapy.utils.conf import arglist_to_dict -from scrapy.exceptions import UsageError, ScrapyDeprecationWarning +from scrapy.exceptions import UsageError class ScrapyCommand(object): @@ -27,31 +26,6 @@ class ScrapyCommand(object): assert not hasattr(self, '_crawler'), "crawler already set" self._crawler = crawler - @property - def crawler(self): - warnings.warn("Command's default `crawler` is deprecated and will be removed. " - "Use `create_crawler` method to instatiate crawlers.", - ScrapyDeprecationWarning) - - if not hasattr(self, '_crawler'): - crawler = self.crawler_process.create_crawler() - - old_start = crawler.start - self.crawler_process.started = False - - def wrapped_start(): - if self.crawler_process.started: - old_start() - else: - self.crawler_process.started = True - self.crawler_process.start() - - crawler.start = wrapped_start - - self.set_crawler(crawler) - - return self._crawler - def syntax(self): """ Command syntax (preferably one-line). Do not include command name.