RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve coverage statscollectors (#7641)

This commit is contained in:
Adrian 2026-06-19 16:59:25 +02:00 committed by GitHub
parent 7b3f88f8ab
commit d2842a205c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scrapy/__main__.py
View File

@ -1,3 +1,4 @@
# pragma: no file cover
from scrapy.cmdline import execute
if __name__ == "__main__":

9
tests/test_stats.py
View File

@ -94,8 +94,13 @@ class TestStatsCollector:
assert stats.get_value("test2") == 35
stats.min_value("test4", 7)
assert stats.get_value("test4") == 7
stats.set_stats({"replaced": "stats"})
assert stats.get_stats() == {"replaced": "stats"}
stats.clear_stats()
assert stats.get_stats() == {}
def test_dummy_collector(self, crawler: Crawler) -> None:
def test_dummy_collector(self) -> None:
crawler = get_crawler(Spider, {"STATS_DUMP": False})
stats = DummyStatsCollector(crawler)
assert stats.get_stats() == {}
assert stats.get_value("anything") is None
@ -104,9 +109,11 @@ class TestStatsCollector:
stats.inc_value("v1")
stats.max_value("v2", 100)
stats.min_value("v3", 100)
stats.set_stats({"key": "val"})
stats.open_spider()
stats.set_value("test", "value")
assert stats.get_stats() == {}
stats.close_spider()
def test_deprecated_spider_arg(self, crawler: Crawler, spider: Spider) -> None:
stats = StatsCollector(crawler)