From d2a9c0fdcd8c3a1466d7a3406731fbe17848d7b5 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Mon, 13 Jun 2011 22:34:01 -0300 Subject: [PATCH] issue deprecation warning when using CLOSESPIDER_ITEMPASSED setting --- scrapy/contrib/closespider.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scrapy/contrib/closespider.py b/scrapy/contrib/closespider.py index 71dd1c1ec..fed26e84a 100644 --- a/scrapy/contrib/closespider.py +++ b/scrapy/contrib/closespider.py @@ -4,6 +4,7 @@ conditions are met. See documentation in docs/topics/extensions.rst """ +import warnings from collections import defaultdict from twisted.internet import reactor @@ -18,8 +19,11 @@ class CloseSpider(object): def __init__(self): self.timeout = settings.getint('CLOSESPIDER_TIMEOUT') - self.itemcount = settings.getint('CLOSESPIDER_ITEMCOUNT') or \ - settings.getint('CLOSESPIDER_ITEMPASSED') # XXX: legacy support + self.itemcount = settings.getint('CLOSESPIDER_ITEMCOUNT') + # XXX: legacy support - remove for future releases + if settings.getint('CLOSESPIDER_ITEMPASSED'): + warnings.warn("CLOSESPIDER_ITEMPASSED setting is deprecated, use CLOSESPIDER_ITEMCOUNT instead", DeprecationWarning) + self.pagecount = settings.getint('CLOSESPIDER_ITEMPASSED') self.pagecount = settings.getint('CLOSESPIDER_PAGECOUNT') self.errorcount = settings.getint('CLOSESPIDER_ERRORCOUNT')