RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a reactor test on Windows.

This commit is contained in:
Andrey Rakhmatullin 2021-12-23 17:40:31 +05:00
parent df04e934e6
commit d4565318c7
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py
View File

@ -2,10 +2,10 @@ import scrapy
from scrapy.crawler import CrawlerProcess
class PollReactorSpider(scrapy.Spider):
name = 'poll_reactor'
class SelectReactorSpider(scrapy.Spider):
name = 'select_reactor'
custom_settings = {
"TWISTED_REACTOR": "twisted.internet.pollreactor.PollReactor",
"TWISTED_REACTOR": "twisted.internet.selectreactor.SelectReactor",
}
@ -17,6 +17,6 @@ class AsyncioReactorSpider(scrapy.Spider):
process = CrawlerProcess()
process.crawl(PollReactorSpider)
process.crawl(SelectReactorSpider)
process.crawl(AsyncioReactorSpider)
process.start()

4
tests/test_crawler.py
View File

@ -381,8 +381,8 @@ class CrawlerProcessSubprocess(ScriptRunnerMixin, unittest.TestCase):
"the asyncio reactor is broken on Windows when running Python ≥ 3.8")
def test_reactor_asyncio_custom_settings_conflict(self):
log = self.run_script("twisted_reactor_custom_settings_conflict.py")
self.assertIn("Using reactor: twisted.internet.pollreactor.PollReactor", log)
self.assertIn("(twisted.internet.pollreactor.PollReactor) does not match the requested one", log)
self.assertIn("Using reactor: twisted.internet.selectreactor.SelectReactor", log)
self.assertIn("(twisted.internet.selectreactor.SelectReactor) does not match the requested one", log)
@mark.skipif(sys.implementation.name == 'pypy', reason='uvloop does not support pypy properly')
@mark.skipif(platform.system() == 'Windows', reason='uvloop does not support Windows')