From d806acdf501757e49cd002581c01cee60e96737e Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Thu, 7 Mar 2013 12:39:40 -0200 Subject: [PATCH] sep-019: minor tide up --- sep/sep-019.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sep/sep-019.rst b/sep/sep-019.rst index 754647a29..d639ffc0e 100644 --- a/sep/sep-019.rst +++ b/sep/sep-019.rst @@ -17,8 +17,17 @@ implementing a class method in your spider:: } +What this solves +================ + +1. true overridable per-spider setting +2. supports accessing settings from spiders (currently not supported wihout + hacky code) +3. avoid mistakenly believing you can change settings after they have been + populated (you can, but they won't have any effect) + Proposed changes ----------------- +================ - new ``custom_settings`` class method will be added to spiders, to give them a chance to override settings *before* they're used to instantiate the crawler @@ -134,15 +143,6 @@ Proposed (new) startup process spider = self.spidercls.from_crawler(self, arg='value') # starts crawling spider -What this solves -================ - -1. true overridable per-spider setting -2. supports accessing settings from spiders (currently not supported wihout - hacky code) -3. avoid mistakenly believing you can change settings after they have been - populated (you can, but they won't have any effect) - TODO ====