From d9b5a64e8fbdf5a3ca99ba531af1ed7156a976ca Mon Sep 17 00:00:00 2001
From: Lia Launtz <liahardin@gmail.com>
Date: Sat, 21 Feb 2026 01:01:34 -0500
Subject: [PATCH] edit command tests adjusted for precommit

---
 tests/test_command_edit.py | 27 +--------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)

diff --git a/tests/test_command_edit.py b/tests/test_command_edit.py
index 209fa16b3..1a040912e 100644
--- a/tests/test_command_edit.py
+++ b/tests/test_command_edit.py
@@ -1,14 +1,10 @@
 from __future__ import annotations
 
-import os
 from pathlib import Path
-from unittest import mock
 
 import pytest
 
-from scrapy.cmdline import ScrapyArgumentParser
 from scrapy.commands.edit import Command
-from scrapy.utils.project import get_project_settings
 from tests.test_commands import TestProjectBase
 from tests.utils.cmdline import call, proc
 
@@ -18,7 +14,7 @@ class TestEditCommand(TestProjectBase):
 
     @pytest.fixture
     def create_spider(self, proj_path: Path):
-        """setup creates spider, teardown removes spider"""
+        """creates spider needed for tests"""
         # setup: create spider to edit
         test_name = "test_name"
         call("genspider", test_name, "test.com", cwd=proj_path)
@@ -37,27 +33,6 @@ class TestEditCommand(TestProjectBase):
         """test call to edit if no spider has been specified"""
         assert call("edit", "not_a_valid_spider", cwd=proj_path) == 1
 
-    def test_edit_implicit(self, create_spider):
-        """tests edit command calls editor"""
-        proj_path, spider, test_name = create_spider
-
-        # change current working directory
-        os.chdir(proj_path)
-
-        # create edit command object
-        cmd = Command()
-        cmd.settings = get_project_settings()
-        editor = cmd.settings.get("EDITOR")
-
-        # parse commandline arguments
-        parser = ScrapyArgumentParser()
-        opts, _ = parser.parse_known_args(["edit", test_name])
-
-        # mock the operating system
-        with mock.patch("scrapy.commands.edit.os.system", return_value=0) as mock_sys:
-            cmd.run([test_name], opts)
-            mock_sys.assert_called_once_with(f'{editor} "{spider}"')
-
     def test_edit_help_syntax(self, proj_path: Path) -> None:
         """Check that long description and syntax are included in edit -h"""
         rtn_code, out, _ = proc("edit", "-h", cwd=proj_path)