From e914556adf8e556d4184db415c49266cc4c91bf5 Mon Sep 17 00:00:00 2001 From: NoExitTV Date: Thu, 5 Oct 2017 15:12:01 +0200 Subject: [PATCH 1/4] Changed the log message to make it more clear. As requested in issue #2927 --- scrapy/core/downloader/handlers/http11.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py index 9bfdd803c..23343d92a 100644 --- a/scrapy/core/downloader/handlers/http11.py +++ b/scrapy/core/downloader/handlers/http11.py @@ -412,9 +412,10 @@ class _ResponseReader(protocol.Protocol): if self._maxsize and self._bytes_received > self._maxsize: logger.error("Received (%(bytes)s) bytes larger than download " - "max size (%(maxsize)s).", + "max size (%(maxsize)s) in request %(request)s.", {'bytes': self._bytes_received, - 'maxsize': self._maxsize}) + 'maxsize': self._maxsize, + 'request': self._request}) # Clear buffer earlier to avoid keeping data in memory for a long # time. self._bodybuf.truncate(0) From 938bc18405ca2cf60836bb8490c391c0fe445af1 Mon Sep 17 00:00:00 2001 From: NoExitTV Date: Thu, 5 Oct 2017 15:31:00 +0200 Subject: [PATCH 2/4] Changed the log message to make it more clear. As requested in issue #2927 --- scrapy/core/downloader/handlers/http11.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py index 23343d92a..0a5538947 100644 --- a/scrapy/core/downloader/handlers/http11.py +++ b/scrapy/core/downloader/handlers/http11.py @@ -344,8 +344,8 @@ class ScrapyAgent(object): if warnsize and expected_size > warnsize: logger.warning("Expected response size (%(size)s) larger than " - "download warn size (%(warnsize)s).", - {'size': expected_size, 'warnsize': warnsize}) + "download warn size (%(warnsize)s) in request (%(request)s).", + {'size': expected_size, 'warnsize': warnsize, 'request': request}) def _cancel(_): # Abort connection inmediately. @@ -412,10 +412,9 @@ class _ResponseReader(protocol.Protocol): if self._maxsize and self._bytes_received > self._maxsize: logger.error("Received (%(bytes)s) bytes larger than download " - "max size (%(maxsize)s) in request %(request)s.", + "max size (%(maxsize)s).", {'bytes': self._bytes_received, - 'maxsize': self._maxsize, - 'request': self._request}) + 'maxsize': self._maxsize}) # Clear buffer earlier to avoid keeping data in memory for a long # time. self._bodybuf.truncate(0) From 345d948f2f55ad81ec7de7cb1f5619d80971a6c0 Mon Sep 17 00:00:00 2001 From: NoExitTV Date: Thu, 5 Oct 2017 15:37:05 +0200 Subject: [PATCH 3/4] Changed the log message to make it more clear. As requested in issue #2927 --- scrapy/core/downloader/handlers/http11.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py index 0a5538947..4e1bb0cd5 100644 --- a/scrapy/core/downloader/handlers/http11.py +++ b/scrapy/core/downloader/handlers/http11.py @@ -344,7 +344,7 @@ class ScrapyAgent(object): if warnsize and expected_size > warnsize: logger.warning("Expected response size (%(size)s) larger than " - "download warn size (%(warnsize)s) in request (%(request)s).", + "download warn size (%(warnsize)s) in request %(request)s.", {'size': expected_size, 'warnsize': warnsize, 'request': request}) def _cancel(_): From 9b8503011e1da0507e82e15631194ed99b7e699a Mon Sep 17 00:00:00 2001 From: NoExitTV Date: Fri, 6 Oct 2017 13:45:35 +0200 Subject: [PATCH 4/4] Changed log message to include information about request as user djunzu commented --- scrapy/core/downloader/handlers/http11.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py index 4e1bb0cd5..48d2481b4 100644 --- a/scrapy/core/downloader/handlers/http11.py +++ b/scrapy/core/downloader/handlers/http11.py @@ -412,9 +412,10 @@ class _ResponseReader(protocol.Protocol): if self._maxsize and self._bytes_received > self._maxsize: logger.error("Received (%(bytes)s) bytes larger than download " - "max size (%(maxsize)s).", + "max size (%(maxsize)s) in request %(request)s.", {'bytes': self._bytes_received, - 'maxsize': self._maxsize}) + 'maxsize': self._maxsize, + 'request': self._request}) # Clear buffer earlier to avoid keeping data in memory for a long # time. self._bodybuf.truncate(0)