From df112a3996fd872b1f6e3fff4a9b989ed4d0aaea Mon Sep 17 00:00:00 2001 From: Andrey Rakhmatullin Date: Tue, 5 Sep 2023 19:43:08 +0400 Subject: [PATCH] Move reactor installation into Crawler.crawl(). --- scrapy/crawler.py | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/scrapy/crawler.py b/scrapy/crawler.py index ec853e0d8..44ffc44ce 100644 --- a/scrapy/crawler.py +++ b/scrapy/crawler.py @@ -104,20 +104,7 @@ class Crawler: crawler=self, ) - reactor_class: str = self.settings["TWISTED_REACTOR"] - event_loop: str = self.settings["ASYNCIO_EVENT_LOOP"] - if init_reactor: - # this needs to be done after the spider settings are merged, - # but before something imports twisted.internet.reactor - if reactor_class: - install_reactor(reactor_class, event_loop) - else: - from twisted.internet import reactor # noqa: F401 - log_reactor_info() - if reactor_class: - verify_installed_reactor(reactor_class) - if is_asyncio_reactor_installed() and event_loop: - verify_installed_asyncio_event_loop(event_loop) + self._init_reactor = init_reactor self.crawling: bool = False self.spider: Optional[Spider] = None @@ -132,8 +119,24 @@ class Crawler: try: self.spider = self._create_spider(*args, **kwargs) self.spider.update_settings(self.settings) - self.settings.freeze() + + reactor_class: str = self.settings["TWISTED_REACTOR"] + event_loop: str = self.settings["ASYNCIO_EVENT_LOOP"] + if self._init_reactor: + # this needs to be done after the spider settings are merged, + # but before something imports twisted.internet.reactor + if reactor_class: + install_reactor(reactor_class, event_loop) + else: + from twisted.internet import reactor # noqa: F401 + log_reactor_info() + if reactor_class: + verify_installed_reactor(reactor_class) + if is_asyncio_reactor_installed() and event_loop: + verify_installed_asyncio_event_loop(event_loop) + self.extensions: ExtensionManager = ExtensionManager.from_crawler(self) + self.settings.freeze() self.engine = self._create_engine() start_requests = iter(self.spider.start_requests())