From e058a05763b45086edaf8b52f067648c0c50ae21 Mon Sep 17 00:00:00 2001
From: Andrey Rakhmatullin <wrar@wrar.name>
Date: Sat, 22 Jul 2023 17:51:13 +0400
Subject: [PATCH] Skip tests that don't work on Python 3.12.

---
 conftest.py                  |  2 ++
 tests/requirements.txt       | 10 ++++++----
 tests/test_feedexport.py     |  3 +++
 tests/test_pipeline_files.py |  5 +++++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/conftest.py b/conftest.py
index fa5193470..635935748 100644
--- a/conftest.py
+++ b/conftest.py
@@ -87,6 +87,8 @@ def requires_uvloop(request):
         pytest.skip("uvloop does not support Windows")
     if twisted_version == Version("twisted", 21, 2, 0):
         pytest.skip("https://twistedmatrix.com/trac/ticket/10106")
+    if sys.version_info >= (3, 12):
+        pytest.skip("uvloop doesn't support Python 3.12 yet")
 
 
 def pytest_configure(config):
diff --git a/tests/requirements.txt b/tests/requirements.txt
index 618949795..37186f3a7 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -1,15 +1,17 @@
 # Tests requirements
 attrs
-pyftpdlib
+# https://github.com/giampaolo/pyftpdlib/issues/560
+pyftpdlib; python_version < "3.12"
 pytest
 pytest-cov==4.0.0
 pytest-xdist
 sybil >= 1.3.0  # https://github.com/cjw296/sybil/issues/20#issuecomment-605433422
 testfixtures
-uvloop; platform_system != "Windows"
+# uvloop currently doesn't build on 3.12
+uvloop; platform_system != "Windows" and python_version < "3.12"
 
-# optional for shell wrapper tests
-bpython
+# bpython requires greenlet which currently doesn't build on 3.12
+bpython; python_version < "3.12"  # optional for shell wrapper tests
 brotli  # optional for HTTP compress downloader middleware tests
 zstandard; implementation_name != 'pypy'  # optional for HTTP compress downloader middleware tests
 ipython
diff --git a/tests/test_feedexport.py b/tests/test_feedexport.py
index 8df86dbd7..eace59d37 100644
--- a/tests/test_feedexport.py
+++ b/tests/test_feedexport.py
@@ -125,6 +125,9 @@ class FileFeedStorageTest(unittest.TestCase):
             path.unlink()
 
 
+@pytest.mark.skipif(
+    sys.version_info >= (3, 12), reason="pyftpdlib doesn't support Python 3.12 yet"
+)
 class FTPFeedStorageTest(unittest.TestCase):
     def get_test_spider(self, settings=None):
         class TestSpider(scrapy.Spider):
diff --git a/tests/test_pipeline_files.py b/tests/test_pipeline_files.py
index 87f3a0295..fe7b26740 100644
--- a/tests/test_pipeline_files.py
+++ b/tests/test_pipeline_files.py
@@ -1,6 +1,7 @@
 import dataclasses
 import os
 import random
+import sys
 import time
 from datetime import datetime
 from io import BytesIO
@@ -11,6 +12,7 @@ from unittest import mock
 from urllib.parse import urlparse
 
 import attr
+import pytest
 from itemadapter import ItemAdapter
 from twisted.internet import defer
 from twisted.trial import unittest
@@ -641,6 +643,9 @@ class TestGCSFilesStore(unittest.TestCase):
                     store.bucket.get_blob.assert_called_with(expected_blob_path)
 
 
+@pytest.mark.skipif(
+    sys.version_info >= (3, 12), reason="pyftpdlib doesn't support Python 3.12 yet"
+)
 class TestFTPFileStore(unittest.TestCase):
     @defer.inlineCallbacks
     def test_persist(self):