RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Engine: remove unnecessary parameter (#5106)

This commit is contained in:
Eugenio Lacuesta 2021-04-20 11:46:43 -03:00 committed by GitHub
parent 7e23677b52
commit e3f81d8d5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scrapy/core/engine.py
View File

@ -161,7 +161,7 @@ class ExecutionEngine:
return None
d = self._download(request, self.spider)
d.addBoth(self._handle_downloader_output, request, self.spider)
d.addBoth(self._handle_downloader_output, request)
d.addErrback(lambda f: logger.info('Error while handling downloader output',
exc_info=failure_to_exc_info(f),
extra={'spider': self.spider}))
@ -176,8 +176,10 @@ class ExecutionEngine:
return d
def _handle_downloader_output(
self, result: Union[Request, Response, Failure], request: Request, spider: Spider
self, result: Union[Request, Response, Failure], request: Request
) -> Optional[Deferred]:
assert self.spider is not None # typing
if not isinstance(result, (Request, Response, Failure)):
raise TypeError(f"Incorrect type: expected Request, Response or Failure, got {type(result)}: {result!r}")
@ -186,12 +188,12 @@ class ExecutionEngine:
self.crawl(result)
return None
d = self.scraper.enqueue_scrape(result, request, spider)
d = self.scraper.enqueue_scrape(result, request, self.spider)
d.addErrback(
lambda f: logger.error(
"Error while enqueuing downloader output",
exc_info=failure_to_exc_info(f),
extra={'spider': spider},
extra={'spider': self.spider},
)
)
return d