RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6235 from elramen/http_request_tests 

Added tests for form.py
This commit is contained in:
Andrey Rakhmatullin 2024-02-22 12:17:11 +05:00 committed by GitHub
parent edd7ba1c06 877398a3de
commit ebd7e199f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
tests/test_http_request.py
View File

@ -1427,6 +1427,58 @@ class FormRequestTest(RequestTest):
r = self.request_class.from_response(response)
self.assertEqual(r.method, expected)
def test_form_response_with_invalid_formdata_type_error(self):
"""Test that a ValueError is raised for non-iterable and non-dict formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=123)
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_form_response_with_custom_invalid_formdata_value_error(self):
"""Test that a ValueError is raised for fault-inducing iterable formdata input"""
response = _buildresponse(
"""<html><body>
<form action="/submit" method="post">
<input type="text" name="test" value="value">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formdata=("a",))
self.assertIn(
"formdata should be a dict or iterable of tuples", str(context.exception)
)
def test_get_form_with_xpath_no_form_parent(self):
"""Test that _get_from raised a ValueError when an XPath selects an element
not nested within a <form> and no <form> parent is found"""
response = _buildresponse(
"""<html><body>
<div id="outside-form">
<p>This paragraph is not inside a form.</p>
</div>
<form action="/submit" method="post">
<input type="text" name="inside-form" value="">
</form>
</body></html>"""
)
with self.assertRaises(ValueError) as context:
FormRequest.from_response(response, formxpath='//div[@id="outside-form"]/p')
self.assertIn("No <form> element found with", str(context.exception))
def _buildresponse(body, **kwargs):
kwargs.setdefault("body", body)