From 6ba0857a5c4fd15cd55c2bd139b216e9ff6f7447 Mon Sep 17 00:00:00 2001 From: Hobson Lane Date: Fri, 10 Jan 2014 10:37:27 -0800 Subject: [PATCH 1/3] documentation code example correction corrections per pablohoffman --- docs/intro/overview.rst | 4 ++++ docs/topics/downloader-middleware.rst | 2 ++ 2 files changed, 6 insertions(+) diff --git a/docs/intro/overview.rst b/docs/intro/overview.rst index b9ecead6c..c2151a0c2 100644 --- a/docs/intro/overview.rst +++ b/docs/intro/overview.rst @@ -135,6 +135,10 @@ For more information about XPath see the `XPath reference`_. Finally, here's the spider code:: + from scrapy.contrib.spiders import CrawlSpider, Rule + from scrapy.contrib.linkextractors.sgml import SgmlLinkExtractor + from scrapy.selectors import Selector + class MininovaSpider(CrawlSpider): name = 'mininova' diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst index 5f8b1c012..cc11c1cf5 100644 --- a/docs/topics/downloader-middleware.rst +++ b/docs/topics/downloader-middleware.rst @@ -281,6 +281,8 @@ HttpAuthMiddleware Example:: + from scrapy.contrib.spiders import CrawlSpider + class SomeIntranetSiteSpider(CrawlSpider): http_user = 'someuser' From a3db95985ba25e16ea88e095886addb95d21b2fa Mon Sep 17 00:00:00 2001 From: Hobson Lane Date: Tue, 14 Jan 2014 21:04:15 -0800 Subject: [PATCH 2/3] another import name correction by pablo --- docs/intro/overview.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/intro/overview.rst b/docs/intro/overview.rst index c2151a0c2..589b048a5 100644 --- a/docs/intro/overview.rst +++ b/docs/intro/overview.rst @@ -137,7 +137,7 @@ Finally, here's the spider code:: from scrapy.contrib.spiders import CrawlSpider, Rule from scrapy.contrib.linkextractors.sgml import SgmlLinkExtractor - from scrapy.selectors import Selector + from scrapy.selector import Selector class MininovaSpider(CrawlSpider): From 85a80d0752935b1af4b14bf446c24cfea800e40d Mon Sep 17 00:00:00 2001 From: Hobson Lane Date: Wed, 15 Jan 2014 17:29:23 -0800 Subject: [PATCH 3/3] remove "for brevity's sake" line and correct "Torrent item" Torrent item -> TorrentItem class --- docs/intro/overview.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/intro/overview.rst b/docs/intro/overview.rst index 589b048a5..c095f5f55 100644 --- a/docs/intro/overview.rst +++ b/docs/intro/overview.rst @@ -155,8 +155,7 @@ Finally, here's the spider code:: torrent['size'] = sel.xpath("//div[@id='info-left']/p[2]/text()[2]").extract() return torrent -For brevity's sake, we intentionally left out the import statements. The -Torrent item is :ref:`defined above `. +The ``TorrentItem`` class is :ref:`defined above `. Run the spider to extract the data ==================================