RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Override request method in FormRequest 

Changes proposed in the comments
This commit is contained in:
Nicolás Ramírez 2013-03-13 13:38:37 -03:00
parent eeb69d2f70
commit f043bba049
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scrapy/http/request/form.py
View File

@ -36,7 +36,8 @@ class FormRequest(Request):
form = _get_form(response, formname, formnumber, formxpath)
formdata = _get_inputs(form, formdata, dont_click, clickdata, response)
url = form.action or form.base_url
return cls(url, method=form.method, formdata=formdata, **kwargs)
method = kwargs.pop('method', form.method)
return cls(url, method=method, formdata=formdata, **kwargs)
def _urlencode(seq, enc):

10
scrapy/tests/test_http_request.py
View File

@ -268,6 +268,16 @@ class FormRequestTest(RequestTest):
self.assertEqual(fs['one'], ['1'])
self.assertEqual(fs['two'], ['2'])
def test_from_response_override_method(self):
response = _buildresponse(
'''<html><body>
<form action="/app"></form>
</body></html>''')
request = FormRequest.from_response(response)
self.assertEqual(request.method, 'GET')
request = FormRequest.from_response(response, method='POST')
self.assertEqual(request.method, 'POST')
def test_from_response_submit_first_clickable(self):
response = _buildresponse(
"""<form action="get.php" method="GET">