mirror of https://github.com/scrapy/scrapy.git
test #8 made tests cleaner
This commit is contained in:
parent
e8e6d28479
commit
f19045403a
|
|
@ -2,7 +2,6 @@ import pickle
|
|||
import re
|
||||
import unittest
|
||||
from typing import Optional
|
||||
from unittest.mock import Mock
|
||||
|
||||
from packaging.version import Version
|
||||
from pytest import mark
|
||||
|
|
@ -854,34 +853,13 @@ class LxmlLinkExtractorTestCase(Base.LinkExtractorTestCase):
|
|||
)
|
||||
|
||||
def test_link_allowed_is_false_with_empty_url(self):
|
||||
mock_link = Mock()
|
||||
mock_link.url = ""
|
||||
expected = False
|
||||
|
||||
actual = LxmlLinkExtractor()._link_allowed(mock_link)
|
||||
|
||||
self.assertEqual(expected, actual)
|
||||
bad_link = Link("")
|
||||
self.assertFalse(LxmlLinkExtractor()._link_allowed(bad_link))
|
||||
|
||||
def test_link_allowed_is_false_with_bad_url_prefix(self):
|
||||
mock_link = Mock()
|
||||
mock_link.url = "htp://should_be_http.com"
|
||||
expected = False
|
||||
|
||||
actual = LxmlLinkExtractor()._link_allowed(mock_link)
|
||||
|
||||
self.assertEqual(expected, actual)
|
||||
bad_link = Link("htp://should_be_http.example")
|
||||
self.assertFalse(LxmlLinkExtractor()._link_allowed(bad_link))
|
||||
|
||||
def test_link_allowed_is_false_with_missing_url_prefix(self):
|
||||
mock_link = Mock()
|
||||
mock_link.url = "should_have_prefix.com"
|
||||
expected = False
|
||||
|
||||
actual = LxmlLinkExtractor()._link_allowed(mock_link)
|
||||
|
||||
self.assertEqual(expected, actual)
|
||||
|
||||
def test_link_allowed_raises_with_none_url(self):
|
||||
mock_link = Mock()
|
||||
mock_link.url = None
|
||||
|
||||
self.assertRaises(AttributeError, LxmlLinkExtractor()._link_allowed, mock_link)
|
||||
bad_link = Link("should_have_prefix.example")
|
||||
self.assertFalse(LxmlLinkExtractor()._link_allowed(bad_link))
|
||||
|
|
|
|||
Loading…
Reference in New Issue