RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove a workaround for a w3lib typing bug.

This commit is contained in:
Andrey Rakhmatullin 2023-08-06 17:46:28 +04:00
parent e2adec629b
commit f5f593e5f5
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scrapy/utils/response.py
View File

@ -42,8 +42,7 @@ def get_meta_refresh(
"""Parse the http-equiv refresh parameter from the given response"""
if response not in _metaref_cache:
text = response.text[0:4096]
# a w3lib typing bug here, fixed in https://github.com/scrapy/w3lib/pull/211
_metaref_cache[response] = html.get_meta_refresh( # type: ignore[assignment]
_metaref_cache[response] = html.get_meta_refresh(
text, response.url, response.encoding, ignore_tags=ignore_tags
)
return _metaref_cache[response]

2
tox.ini
View File

@ -41,6 +41,8 @@ deps =
types-Pygments==2.15.0.1
types-pyOpenSSL==23.2.0.1
types-setuptools==68.0.0.1
# 2.1.2 fixes a typing bug: https://github.com/scrapy/w3lib/pull/211
w3lib >= 2.1.2
commands =
mypy {posargs: scrapy tests}