From f6807f7d6f7ad66a36a90145b5342f91c2e91bc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Thu, 28 Dec 2023 15:47:49 +0100 Subject: [PATCH] Fix the initialization of RedirectMiddleware.from_crawler in some tests --- tests/test_downloadermiddleware_cookies.py | 3 +-- tests/test_spidermiddleware_referer.py | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_downloadermiddleware_cookies.py b/tests/test_downloadermiddleware_cookies.py index 4a81a638e..1b1a580fe 100644 --- a/tests/test_downloadermiddleware_cookies.py +++ b/tests/test_downloadermiddleware_cookies.py @@ -9,7 +9,6 @@ from scrapy.downloadermiddlewares.defaultheaders import DefaultHeadersMiddleware from scrapy.downloadermiddlewares.redirect import RedirectMiddleware from scrapy.exceptions import NotConfigured from scrapy.http import Request, Response -from scrapy.settings import Settings from scrapy.spiders import Spider from scrapy.utils.python import to_bytes from scrapy.utils.test import get_crawler @@ -61,7 +60,7 @@ class CookiesMiddlewareTest(TestCase): def setUp(self): self.spider = Spider("foo") self.mw = CookiesMiddleware() - self.redirect_middleware = RedirectMiddleware(settings=Settings()) + self.redirect_middleware = RedirectMiddleware.from_crawler(get_crawler(Spider)) def tearDown(self): del self.mw diff --git a/tests/test_spidermiddleware_referer.py b/tests/test_spidermiddleware_referer.py index afffa87fb..66dcc0d3f 100644 --- a/tests/test_spidermiddleware_referer.py +++ b/tests/test_spidermiddleware_referer.py @@ -29,6 +29,7 @@ from scrapy.spidermiddlewares.referer import ( UnsafeUrlPolicy, ) from scrapy.spiders import Spider +from scrapy.utils.test import get_crawler class TestRefererMiddleware(TestCase): @@ -961,7 +962,7 @@ class TestReferrerOnRedirect(TestRefererMiddleware): self.spider = Spider("foo") settings = Settings(self.settings) self.referrermw = RefererMiddleware(settings) - self.redirectmw = RedirectMiddleware(settings) + self.redirectmw = RedirectMiddleware.from_crawler(get_crawler(Spider)) def test(self): for (