From f6ae78f4b1de7f12e880d85109e78c3c808f852a Mon Sep 17 00:00:00 2001 From: Mikhail Korobov Date: Wed, 3 Jun 2015 04:29:10 +0500 Subject: [PATCH] fixed spider custom_settings https://github.com/scrapy/scrapy/pull/1128 moved spidercls.update_settings call to a later stage; this commit moves it back. --- scrapy/crawler.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scrapy/crawler.py b/scrapy/crawler.py index 2cd658276..204395c77 100644 --- a/scrapy/crawler.py +++ b/scrapy/crawler.py @@ -29,6 +29,7 @@ class Crawler(object): self.spidercls = spidercls self.settings = settings.copy() + self.spidercls.update_settings(self.settings) self.signals = SignalManager(self) self.stats = load_object(self.settings['STATS_CLASS'])(self) @@ -44,9 +45,7 @@ class Crawler(object): self.logformatter = lf_cls.from_crawler(self) self.extensions = ExtensionManager.from_crawler(self) - self.spidercls.update_settings(self.settings) self.settings.freeze() - self.crawling = False self.spider = None self.engine = None