From fd58de493c3b7044bd3a93040d3e40ae56927113 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Gra=C3=B1a?= <dangra@gmail.com>
Date: Wed, 5 Dec 2012 10:56:42 -0200
Subject: [PATCH] Remove concurrency limitation when using download delays and
 still ensure inter-request delays are enforced

---
 scrapy/core/downloader/__init__.py | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/scrapy/core/downloader/__init__.py b/scrapy/core/downloader/__init__.py
index 042f78075..e5db35325 100644
--- a/scrapy/core/downloader/__init__.py
+++ b/scrapy/core/downloader/__init__.py
@@ -27,6 +27,7 @@ class Slot(object):
         self.queue = deque()
         self.transferring = set()
         self.lastseen = 0
+        self.latercall = None
 
     def free_transfer_slots(self):
         return self.concurrency - len(self.transferring)
@@ -57,9 +58,6 @@ def _get_concurrency_delay(concurrency, spider, settings):
     if hasattr(spider, 'max_concurrent_requests'):
         concurrency = spider.max_concurrent_requests
 
-    if delay > 0:
-        concurrency = 1 # force concurrency=1 if download delay required
-
     return concurrency, delay
 
 
@@ -87,6 +85,7 @@ class Downloader(object):
             slot.active.remove(request)
             if not slot.active: # remove empty slots
                 self.inactive_slots[key] = self.slots.pop(key)
+
             return response
 
         dlfunc = partial(self._enqueue_request, slot=slot)
@@ -124,23 +123,28 @@ class Downloader(object):
         return deferred
 
     def _process_queue(self, spider, slot):
+        if slot.latercall and slot.latercall.active():
+            return
+
         # Delay queue processing if a download_delay is configured
         now = time()
         delay = slot.download_delay()
         if delay:
             penalty = delay - now + slot.lastseen
-            if penalty > 0 and slot.free_transfer_slots():
-                d = defer.Deferred()
-                d.addCallback(self._process_queue, slot)
-                reactor.callLater(penalty, d.callback, spider)
+            if penalty > 0:
+                slot.latercall = reactor.callLater(penalty, self._process_queue, spider, slot)
                 return
-        slot.lastseen = now
 
         # Process enqueued requests if there are free slots to transfer for this slot
         while slot.queue and slot.free_transfer_slots() > 0:
+            slot.lastseen = now
             request, deferred = slot.queue.popleft()
             dfd = self._download(slot, request, spider)
             dfd.chainDeferred(deferred)
+            # prevent burst if inter-request delays were configured
+            if delay:
+                self._process_queue(spider, slot)
+                break
 
     def _download(self, slot, request, spider):
         # The order is very important for the following deferreds. Do not change!