From fd7b40e892e36a613993a21ad5305ff9f0602491 Mon Sep 17 00:00:00 2001 From: tpeng Date: Tue, 18 Mar 2014 15:23:25 +0800 Subject: [PATCH] add message when raise IngoreReques; fix item_scraped document --- docs/topics/signals.rst | 8 ++++---- scrapy/contrib/downloadermiddleware/redirect.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/topics/signals.rst b/docs/topics/signals.rst index 7923db332..cf8fff6a9 100644 --- a/docs/topics/signals.rst +++ b/docs/topics/signals.rst @@ -63,7 +63,7 @@ item_scraped ------------ .. signal:: item_scraped -.. function:: item_scraped(item, response, spider) +.. function:: item_scraped(item, spider, response) Sent when an item has been scraped, after it has passed all the :ref:`topics-item-pipeline` stages (without being dropped). @@ -73,12 +73,12 @@ item_scraped :param item: the item scraped :type item: :class:`~scrapy.item.Item` object - :param response: the response from where the item was scraped - :type response: :class:`~scrapy.http.Response` object - :param spider: the spider which scraped the item :type spider: :class:`~scrapy.spider.Spider` object + :param response: the response from where the item was scraped + :type response: :class:`~scrapy.http.Response` object + item_dropped ------------ diff --git a/scrapy/contrib/downloadermiddleware/redirect.py b/scrapy/contrib/downloadermiddleware/redirect.py index b31657afb..1b36a7eae 100644 --- a/scrapy/contrib/downloadermiddleware/redirect.py +++ b/scrapy/contrib/downloadermiddleware/redirect.py @@ -39,7 +39,7 @@ class BaseRedirectMiddleware(object): else: log.msg(format="Discarding %(request)s: max redirections reached", level=log.DEBUG, spider=spider, request=request) - raise IgnoreRequest + raise IgnoreRequest("max redirections reached") def _redirect_request_using_get(self, request, redirect_url): redirected = request.replace(url=redirect_url, method='GET', body='')