Commit Graph

16 Commits

Author SHA1 Message Date
Simon Diviani Gartz 21d794d35a Fixes conversion of transparent PNG with palette images to jpg #2452 2017-03-22 13:29:15 +01:00
Paul Tremberth 5efd65255c TST: Randomize IMAGES_EXPIRES above 90 days 2016-12-06 18:49:53 +01:00
pawelmhm 7d88209543 [image & file pipeline] loading setting for user classes
if user has some custom subclass of Image pipeline and no setting for
this pipeline, he should get default settings defined for Image Pipeline.

Fixes #2198
2016-09-15 09:39:16 +02:00
Jesús Losada 7c3e3b484e Fix ImagesPipeline test settings 2016-07-22 20:03:49 +02:00
Pawel Miech fa4d0cdfe5 [FilesPipeline, ImagesPipeline] fix for cls attrs with DEFAULT prefix
some class attributes for ImagePipeline and FilesPipeline had DEFAULT prefix. These
attributes should be preserved as well, if users subclasses define values for
DEFAULT_<CLS_ATTRIBUTE_NAME> attribute this value should be preserved.
2016-06-20 12:53:20 +02:00
Pawel Miech 72e4d5f33e [image_pipeline] another test for subclass inheritance
test case when subclass inherits from base class and has no attributes nor
settings defined.
2016-06-15 14:07:17 +02:00
Pawel Miech ee39d11e45 [image_pipeline] refactor and simplify tests for image settings
unify tests that test same thing for different attribute values into one. Add
better docstrings for tests.
2016-06-15 11:25:38 +02:00
Pawel Miech d715172528 [image_pipeline] unify and simplify tests for setting loading
there was identical test for different setting keys. I unified it into
one unit test.

Fixes comments for tests, adds comments about intention of uppercase attrs.

Adds another test for user defined setting keys and uppercase attrs.
2016-06-14 19:09:56 +02:00
Pawel Miech a62d4b081c [image-pipeline] image settings with class name
allow to have image settings with class name, so that settings for user defined ImagePipeline
subclasses can be defined easily.
2016-06-10 12:48:02 +02:00
Pawel Miech 6c67db3917 [image_pipeline] tests for class attrs backward compatibility
and docs about image pipeline settings.
2016-05-18 12:04:52 +02:00
Pawel Miech 4cef1a1d00 [image_pipeline] bring back uppercase pipeline attributes
allow users to have class attributes on image pipelines. This assumes
that class attributes are useful if users want to have different pipeline
classes inhriting from ImagePipeline.
2016-05-13 12:35:35 +02:00
djunzu e9d48f8a8e Add tests.
modified:   tests/test_pipeline_files.py
	modified:   tests/test_pipeline_images.py
2016-03-31 19:19:49 -03:00
nyov 34eced0ee8 PY3 fix tests pipelines images 2015-08-08 04:23:06 +05:00
Julia Medina 8021df18d4 Move scrapy/contrib/pipeline to scrapy/pipelines 2015-04-29 21:26:35 -03:00
Mikhail Korobov 39635e5f55 Allow spiders to return dicts. See GH-1064. 2015-03-18 07:26:56 +05:00
Daniel Graña 242c08553f move tests under root dir 2014-07-30 19:45:08 -03:00