Commit Graph

53 Commits

Author SHA1 Message Date
Emmanuel Rondan e211ec0aa2 adding black formatter to all the code 2022-11-29 11:30:46 -03:00
Andrey Rahmatullin bbe24d79a5
Fix test issues 2022-11-07 17:08:54 +05:00
Andrey Rahmatullin 6c0890ff54
Simplify the changes after the merge 2022-11-07 16:36:54 +05:00
Andrey Rahmatullin b03d84e9fb
Merge branch 'master' into 3689-update 2022-11-07 16:33:21 +05:00
Andrey Rakhmatullin ca50af6453 Remove an unused import. 2022-10-27 17:12:26 +06:00
Andrey Rahmatullin 5780ccba55
Merge branch 'master' into deprecate-NoimagesDrop 2022-10-27 15:46:32 +05:00
Mikhail Korobov 1054689593 remove unused imports
thanks flake8!
2022-07-18 23:53:30 +05:00
Mikhail Korobov e248360e6e remove compatibility code from tests for the case dataclasses module is not available
It was Python 3.6 compat code, and Python 3.6 support is dropped.
2022-07-18 23:49:08 +05:00
Mohammadtaher Abbasi 5c586d78f0 add tests 2022-05-25 23:58:09 +04:30
PluT00 cc16af35af Add deprecation warning test for scrapy.pipelines.images.NoimagesDrop 2022-05-03 11:29:21 +03:00
Adrián Chaves 308a58aa27
Update CI to support Twisted 21.2.0 (#5027) 2021-03-19 18:39:44 +01:00
D R Siddhartha 0c24cdb257 Improved warning messages a little 2020-10-04 02:09:21 +05:30
drs-11 35e2d25689 Merge remote-tracking branch 'upstream/master' into 3689-update 2020-09-02 20:51:09 +05:30
drs-11 6565adc471 added test case for get_images 2020-09-02 20:44:26 +05:30
Ammar Najjar 58ca8bbf6d Use f-strings (#4307) 2020-08-26 07:11:05 +02:00
drs-11 1f9598ada4 Update branch to latest 2020-08-25 02:14:22 +05:30
drs-11 8b84a65a6b cleaned up code relating to issue #3689 2020-08-25 00:30:17 +05:30
Eugenio Lacuesta ec98dabfab
Support for dataclass and attrs items (#3881) 2020-06-14 11:45:27 +02:00
Eugenio Lacuesta 3eeecb4273
Merge branch 'master' into flake8-max-line-length 2020-05-15 11:11:20 -03:00
Marc Hernández fffb0a5b6a
replace set constructor with set literals (#4573) 2020-05-15 15:23:09 +02:00
Eugenio Lacuesta 6f8758624c
Flake8: remove F841 2020-05-11 13:50:34 -03:00
Eugenio Lacuesta 182394bcec
E501 compliance (tests) 2020-03-22 23:29:30 -03:00
Marc Hernández 91bbc70bc1
fix E30X flake8 (#4355) 2020-02-21 06:05:31 +01:00
Adrián Chaves a2bf340bab Remove unused imports 2019-11-21 14:21:17 +01:00
nyov 7a398b7086 Deprecation removals for Scrapy 1.7
Removing deprecations of 2015 and prior (pre-1.1)
2019-07-06 13:41:56 +00:00
Anubhav Patel 2994b624e0 makes suggested changes 2019-05-17 12:14:43 +00:00
Anubhav Patel 653ac3eebe makes suggested changes 2019-05-16 06:20:39 +00:00
Anubhav Patel 881bade2c1 tests for new API 2019-05-07 16:12:26 +05:30
Anubhav Patel 33925a7761 test for deprecation warning 2019-05-07 15:44:21 +05:30
Anubhav Patel 2a6bcdb413 makes fix backward compatible 2019-04-29 21:21:02 +05:30
Anubhav Patel 6039b66f42 aesthetic changes 2019-04-13 10:17:26 +05:30
Anubhav Patel c6769d6887 make suggested changes 2019-04-13 10:10:08 +05:30
Anubhav Patel 398639a0bf fix test 2019-04-08 12:27:36 +05:30
Anubhav Patel ca882d8d9f include test 2019-03-27 19:10:44 +05:30
Anubhav Patel 07487dd487 make tests work with new convert_image 2019-03-15 23:29:53 +05:30
Mikhail Korobov fac1b2f351 TST remove workaround for old Pillow versions which don't support BytesIO 2018-06-28 01:01:27 +05:00
Chomba Ng'ang'a 4ca61a2051 Update deprecated test aliases
- change ``failIf`` to ``assertFalse``
- change ``asertEquals`` to ``assertEqual``
- change ``assert_`` to ``assertTrue``

https://docs.python.org/2/library/unittest.html#deprecated-aliases
2017-08-09 12:52:10 +02:00
Simon Diviani Gartz 21d794d35a Fixes conversion of transparent PNG with palette images to jpg #2452 2017-03-22 13:29:15 +01:00
Paul Tremberth 5efd65255c TST: Randomize IMAGES_EXPIRES above 90 days 2016-12-06 18:49:53 +01:00
pawelmhm 7d88209543 [image & file pipeline] loading setting for user classes
if user has some custom subclass of Image pipeline and no setting for
this pipeline, he should get default settings defined for Image Pipeline.

Fixes #2198
2016-09-15 09:39:16 +02:00
Jesús Losada 7c3e3b484e Fix ImagesPipeline test settings 2016-07-22 20:03:49 +02:00
Pawel Miech fa4d0cdfe5 [FilesPipeline, ImagesPipeline] fix for cls attrs with DEFAULT prefix
some class attributes for ImagePipeline and FilesPipeline had DEFAULT prefix. These
attributes should be preserved as well, if users subclasses define values for
DEFAULT_<CLS_ATTRIBUTE_NAME> attribute this value should be preserved.
2016-06-20 12:53:20 +02:00
Pawel Miech 72e4d5f33e [image_pipeline] another test for subclass inheritance
test case when subclass inherits from base class and has no attributes nor
settings defined.
2016-06-15 14:07:17 +02:00
Pawel Miech ee39d11e45 [image_pipeline] refactor and simplify tests for image settings
unify tests that test same thing for different attribute values into one. Add
better docstrings for tests.
2016-06-15 11:25:38 +02:00
Pawel Miech d715172528 [image_pipeline] unify and simplify tests for setting loading
there was identical test for different setting keys. I unified it into
one unit test.

Fixes comments for tests, adds comments about intention of uppercase attrs.

Adds another test for user defined setting keys and uppercase attrs.
2016-06-14 19:09:56 +02:00
Pawel Miech a62d4b081c [image-pipeline] image settings with class name
allow to have image settings with class name, so that settings for user defined ImagePipeline
subclasses can be defined easily.
2016-06-10 12:48:02 +02:00
Pawel Miech 6c67db3917 [image_pipeline] tests for class attrs backward compatibility
and docs about image pipeline settings.
2016-05-18 12:04:52 +02:00
Pawel Miech 4cef1a1d00 [image_pipeline] bring back uppercase pipeline attributes
allow users to have class attributes on image pipelines. This assumes
that class attributes are useful if users want to have different pipeline
classes inhriting from ImagePipeline.
2016-05-13 12:35:35 +02:00
djunzu e9d48f8a8e Add tests.
modified:   tests/test_pipeline_files.py
	modified:   tests/test_pipeline_images.py
2016-03-31 19:19:49 -03:00
nyov 34eced0ee8 PY3 fix tests pipelines images 2015-08-08 04:23:06 +05:00