Commit Graph

6 Commits

Author SHA1 Message Date
winklemad 6f44e92dc9 Dedupe the submit button against list formdata in FormRequest.from_response
When formdata is a list of (key, value) tuples rather than a dict,
from_response() failed to suppress the form's own submit button: the
clickable de-dup tested `clickable[0] not in formdata`, which for a list
compares the name string against tuples and is always true, so the form's
default submit value was emitted in addition to the caller's override.
Dedup against `formdata_keys` instead -- it already normalizes both dict and
list-of-tuples and is what the regular-input de-dup on the line above uses,
so both container types now behave the same.
2026-07-11 04:13:13 +05:30
Adrian cf5607f8bc
Undeprecated the basic FormRequest API (#7671) 2026-06-26 17:35:46 +02:00
Adrian 0007676e8d
Improve test coverage for http/ (#7672)
* Improve test coverage for http/

* Use isinstance() instead of type()
2026-06-26 12:21:12 +05:00
Andrey Rakhmatullin 33452f3aeb
Silence deprecation warnings in TestFormRequest. (#7491) 2026-05-04 22:20:21 +02:00
Adrián Chaves 8d69a7c865
Deprecate FormRequest in favor of form2request (#6438)
* WIP

* Add docs

* Remove FormRequest from tests

* Silence mypy issue

* Address docs-tests issues

---------

Co-authored-by: Adrian Chaves <adrian@zyte.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-05-04 22:38:29 +05:00
Andrey Rakhmatullin 584d99af30
Split long test files (#7329) 2026-03-13 10:30:25 +01:00