Jacty
33ab0a3663
Update __init__.py
2020-05-13 06:11:07 +08:00
Aditya Kumar
8d1269bcbc
Cover chompjs in documentation ( #4562 )
2020-05-12 20:42:28 +02:00
Aditya Kumar
97532a9144
test(spiderloader): no duplicate spider names ( #4560 )
2020-05-12 17:10:09 +02:00
Jay Rajput
07e125f4c9
Travis CI fixes in __init__.py
2020-05-12 16:31:56 +05:30
Jay Rajput
28d223dd87
Update __init__.py
2020-05-12 15:28:22 +05:30
Jay Rajput
e01c30f0d5
Update scrapy/commands/__init__.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-05-12 01:05:20 +05:30
willbeaufoy
cf9be5344a
Prevent create_instance() returning None ( #4532 )
...
Currently create_instance() can return None if an extension is
incorrectly implemented, but the extension will still show up as
enabled in the logs. This can cause confusion, as in the linked bug.
This change prevents this occurring by throwing an error if
create_instance() will return None.
2020-05-11 20:35:25 +02:00
nsirletti
cb8140a42a
Deprecate Response.body_as_unicode() ( #4555 )
...
Co-authored-by: Nicolas Sirletti <n.sirletti@gmail.com>
2020-05-11 20:20:31 +02:00
Eugenio Lacuesta
6f8758624c
Flake8: remove F841
2020-05-11 13:50:34 -03:00
Eugenio Lacuesta
25e9bc2d0d
Merge branch 'master' into flake8-remove-e128
2020-05-11 13:23:57 -03:00
Eugenio Lacuesta
abfdc1b542
Update docstring for Item class
2020-05-11 13:20:06 -03:00
Eugenio Lacuesta
fb7ba6964d
Merge branch 'master' into deprecate-baseitem
2020-05-11 10:21:56 -03:00
Mikhail Korobov
892467cb8a
Merge pull request #4541 from elacuesta/pickle-adjustments
...
Pickle: use protocol 4, update tests
2020-05-11 15:16:14 +05:00
Mikhail Korobov
b183579564
Merge pull request #4205 from elacuesta/bytes_received_signal
...
Add bytes_received signal
2020-05-11 15:09:55 +05:00
Jacty
b5684909d1
Unnecessary update when value is None
...
When value is None, it is not necessary to invoke update and run other methods and conditions to make the code complicated there.
2020-05-11 11:18:25 +08:00
Will Beaufoy
1bfbcc6180
Extend hoverxref_roles to custom crossrefs ( #4495 )
2020-05-10 13:49:13 +01:00
Jay Rajput
02ac6664a5
Travis CI fixes
2020-05-10 00:26:48 +05:30
Jay Rajput
ed4f4f8408
Applied suggested format changes
2020-05-10 00:08:34 +05:30
Adrián Chaves
e07708e374
request-response: update the consequences of str(b'')
2020-05-09 15:54:31 +02:00
Adrián Chaves
c6746f0e38
bytes array → bytes object
2020-05-09 15:51:11 +02:00
Jay Rajput
92792cc3f7
Moved common_commands.py to __init__.py
2020-05-09 17:28:10 +05:30
Eugenio Lacuesta
f689e917bf
Update Item docstring
2020-05-08 19:44:05 -03:00
Eugenio Lacuesta
9485724d98
Merge branch 'master' into deprecate-baseitem
2020-05-08 19:32:47 -03:00
Eugenio Lacuesta
be39f274b8
Merge branch 'master' into flake8-remove-e128
2020-05-08 18:33:29 -03:00
Mikhail Korobov
794ab19660
Merge pull request #3727 from Gallaecio/pylint
...
Use pylint
2020-05-09 02:22:54 +05:00
Mikhail Korobov
333910f6c8
Merge pull request #4554 from elacuesta/linkextractor-remove-lambdas
...
Remove lambda attributes in default link extractor
2020-05-09 02:11:59 +05:00
Mikhail Korobov
707f591767
Merge pull request #4557 from elacuesta/flake8-remove-e1xx
...
Flake8: remove E111, E114, E116, E117, E121
2020-05-09 02:08:27 +05:00
Eugenio Lacuesta
c2c3054ac1
Flake8: remove E121
2020-05-08 16:43:47 -03:00
Eugenio Lacuesta
83ce82f400
Flake8: remove E114 and E117 (unused)
2020-05-08 16:43:28 -03:00
Eugenio Lacuesta
1a157f2e26
Flake8: remove E116
2020-05-08 16:42:56 -03:00
Eugenio Lacuesta
81d0b2f61a
Flake8: remove E111
2020-05-08 16:42:50 -03:00
Eugenio Lacuesta
3ebf2a0d82
Remove lambdas in link extractor
2020-05-08 15:24:37 -03:00
Eugenio Lacuesta
b852fff6f8
Style changes in link extractor
2020-05-08 15:22:41 -03:00
Antonio Gordillo Toledo
cf09af787e
Remove Python 2 encoding header from files ( #4553 )
2020-05-08 15:45:19 +02:00
Jay Rajput
dcf7235f0e
Code sharing between crawl and runspider command
2020-05-08 01:48:23 +05:30
Eugenio Lacuesta
38f01dd243
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128
2020-05-07 14:52:31 -03:00
Eugenio Lacuesta
6160370927
Merge remote-tracking branch 'upstream/master' into deprecate-baseitem
2020-05-07 14:38:54 -03:00
Eugenio Lacuesta
5256eae60d
Meta class to handle isinstance checks for BaseItem
2020-05-07 14:37:41 -03:00
Mikhail Korobov
77492cd945
Merge pull request #4543 from elacuesta/flake8-remove-e126
...
Flake8: remove E126
2020-05-07 22:14:51 +05:00
Eugenio Lacuesta
8b4485134e
Merge branch 'flake8-remove-e126' into flake8-remove-e128
2020-05-07 12:50:20 -03:00
Eugenio Lacuesta
e0127a3123
Refactor warnings in spiderloader
2020-05-07 12:48:43 -03:00
Eugenio Lacuesta
8659b0d896
Merge remote-tracking branch 'upstream/master' into flake8-remove-e126
2020-05-07 09:24:38 -03:00
Eugenio Lacuesta
422e6429b5
Add mising len check in spiderloader
2020-05-07 09:22:14 -03:00
Adrián Chaves
b59dfb75fa
Update disabled Pylint checks
2020-05-07 14:15:37 +02:00
Adrián Chaves
4605c66a80
Fix AttributeError
2020-05-07 12:38:51 +02:00
Mikhail Korobov
a8f61e909f
Merge pull request #4544 from elacuesta/flake8-remove-e129
...
Flake8: remove E129
2020-05-07 15:08:11 +05:00
Mikhail Korobov
a18bfccac2
Merge pull request #4542 from elacuesta/flake8-remove-e122-e124
...
Flake8: remove E122 and E124
2020-05-07 15:05:01 +05:00
Adrián Chaves
bbd9d05dbf
request-response.rst: review type references around body mentions
2020-05-07 11:44:43 +02:00
Eugenio Lacuesta
7fd2085725
Merge remote-tracking branch 'upstream/master' into bytes_received_signal
2020-05-06 22:41:16 -03:00
Eugenio Lacuesta
d472402a02
Fix pickle test for pypy
2020-05-06 20:30:22 -03:00