RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
scrapy/tests
History
Adnan Awan 5d91ea12d6
Fix JsonItemExporter puts lone comma in the output if encoder fails (#5952) 
* Partial fix for #3090 - only addresses JSON feeds.

* Adding test case for #3090 to Json Exporter

* Changing the deliberate-fail JSON example to a complex

* Further tightening JsonItemExporter behaviour to prevent corruption.

Based on Mikhail's observation that to_bytes can fail also, leading
to the same dangling comma as the failure to encode to JSON.

Added a new test case to avoid reversion.

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Add initial changes from cathal's PR
- https://github.com/scrapy/scrapy/issues/3090

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Handle exception not to add empty item.
- https://github.com/scrapy/scrapy/issues/3090

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Add comment for handling the exception
- https://github.com/scrapy/scrapy/issues/3090

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Remove unused import
- https://github.com/scrapy/scrapy/issues/3090

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Fix invalid json issue
- https://github.com/scrapy/scrapy/issues/3090

* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails

- Perform CR changes
- https://github.com/scrapy/scrapy/issues/3090

---------

Co-authored-by: Cathal Garvey <cathalgarvey@cathalgarvey.me>
 		2023-07-22 23:13:40 +05:00
..
CrawlerProcess sort imports with isort 2023-01-25 14:25:15 -06:00
CrawlerRunner Ignore typing for twisted.internet.reactor globally. 2023-01-27 23:19:44 +04:00
keys sort imports with isort 2023-01-25 14:25:15 -06:00
mocks adding black formatter to all the code 2022-11-29 11:30:46 -03:00
sample_data reaplying black, fixing conflicts and ignoring bandit checks on test directory 2023-01-20 10:55:46 -03:00
test_cmdline Improve finding tests.test_cmdline.settings. 2023-06-12 21:50:29 +04:00
test_cmdline_crawl_with_pipeline sort imports with isort 2023-01-25 14:25:15 -06:00
test_settings fix: Return value instead of `SettingsAttribute` object when using `pop` method (#5963) 2023-06-28 08:28:49 +02:00
test_spiderloader Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_utils_misc sort imports with isort 2023-01-25 14:25:15 -06:00
__init__.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
ftpserver.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
ignores.txt Remove deprecated classes BaseSgmlLinkExtractor, RegexLinkExtractor and SgmlLinkExtractor (#4356) 2020-07-17 12:40:04 +02:00
mockserver.py Don't rely on get_testenv() for running mockserver. 2023-06-04 19:59:58 +04:00
pipelines.py reaplying black, fixing conflicts and ignoring bandit checks on test directory 2023-01-20 10:55:46 -03:00
requirements.txt Skip tests that don't work on Python 3.12. 2023-07-22 17:51:13 +04:00
spiders.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_closespider.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_command_check.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_command_fetch.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_command_parse.py Fix parse command issues with asyncio (#5824) 2023-03-10 16:20:15 +01:00
test_command_shell.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_command_version.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_commands.py Simplify skipping uvloop tests. 2023-07-22 17:44:37 +04:00
test_contracts.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_core_downloader.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_crawl.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_crawler.py Simplify skipping uvloop tests. 2023-07-22 17:44:37 +04:00
test_dependencies.py Remove obsolete top-level run code in tests. 2023-01-25 22:14:24 +04:00
test_downloader_handlers.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_downloader_handlers_http2.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_downloadermiddleware.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_downloadermiddleware_ajaxcrawlable.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_cookies.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_decompression.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_downloadermiddleware_defaultheaders.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_downloadtimeout.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_httpauth.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_httpcache.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_downloadermiddleware_httpcompression.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_httpproxy.py Merge remote-tracking branch 'origin/master' into mypy-imports 2023-02-11 22:02:19 +04:00
test_downloadermiddleware_redirect.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloadermiddleware_retry.py Make the retry middleware exception list configurable (#5929) 2023-06-16 15:46:06 +02:00
test_downloadermiddleware_robotstxt.py Merge branch 'master' into no-callback 2023-01-30 15:43:05 +05:00
test_downloadermiddleware_stats.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_downloadermiddleware_useragent.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_downloaderslotssettings.py per_slot_settings(docs): code style fix 3 (from previous pre-commit check) 2023-02-16 18:19:36 +02:00
test_dupefilters.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_engine.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_engine_stop_download_bytes.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_engine_stop_download_headers.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_exporters.py Fix JsonItemExporter puts lone comma in the output if encoder fails (#5952) 2023-07-22 23:13:40 +05:00
test_extension_telnet.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_feedexport.py Skip tests that don't work on Python 3.12. 2023-07-22 17:51:13 +04:00
test_http2_client_protocol.py Merge remote-tracking branch 'origin/master' into mypy-imports 2023-02-11 22:02:19 +04:00
test_http_cookies.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_http_headers.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_http_request.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_http_response.py Merge pull request #5915 from jxlil/feature/support-parsel-jmespath 2023-05-03 13:18:39 +04:00
test_item.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_link.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_linkextractors.py Skip test_skip_bad_links based on the w3lib version 2023-04-12 09:28:28 +02:00
test_loader.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_loader_deprecated.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_logformatter.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_mail.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_middleware.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_pipeline_crawl.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_pipeline_files.py Skip tests that don't work on Python 3.12. 2023-07-22 17:51:13 +04:00
test_pipeline_images.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_pipeline_media.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_pipelines.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_pqueues.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_proxy_connect.py Don't rely on get_testenv() for running mockserver. 2023-06-04 19:59:58 +04:00
test_request_attribute_binding.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_request_cb_kwargs.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_request_dict.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_request_left.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_responsetypes.py chore: add tests 2023-05-02 12:53:04 -03:00
test_robotstxt_interface.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_scheduler.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_scheduler_base.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_selector.py fix: tests/tes_selector.py 2023-05-02 19:40:04 -06:00
test_signals.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_spider.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_spidermiddleware.py Merge remote-tracking branch 'origin/master' into mypy-imports 2023-02-11 22:02:19 +04:00
test_spidermiddleware_depth.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_spidermiddleware_httperror.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_spidermiddleware_offsite.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_spidermiddleware_output_chain.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_spidermiddleware_referer.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_spidermiddleware_urllength.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_spiderstate.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_squeues.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_squeues_request.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_stats.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_toplevel.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_urlparse_monkeypatches.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_asyncgen.py Implement spider middleware iterable upgrade/downgrade. 2022-01-11 18:28:32 +05:00
test_utils_asyncio.py Actually run test_set_asyncio_event_loop(). 2023-06-14 18:23:29 +04:00
test_utils_conf.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_console.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_utils_curl.py feat: added test_post_data_raw_with_string_prefix 2023-04-18 22:28:16 -05:00
test_utils_datatypes.py Merge branch 'master' into case-insensitive-dict 2023-06-21 22:12:44 +04:00
test_utils_defer.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_deprecate.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_display.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_gz.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_utils_httpobj.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_utils_iterators.py IOError and other cleanup (#4716) 2023-06-21 20:08:53 +02:00
test_utils_log.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_project.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_python.py Improve get_func_args (#5885) 2023-04-13 11:44:20 +02:00
test_utils_request.py Implement a request_to_curl function (#5892) 2023-04-13 17:46:59 +02:00
test_utils_response.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_serialize.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_signal.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_utils_sitemap.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_utils_spider.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_utils_template.py Upgrade CI tools 2023-02-02 06:37:40 +01:00
test_utils_trackref.py adding black formatter to all the code 2022-11-29 11:30:46 -03:00
test_utils_url.py sort imports with isort 2023-01-25 14:25:15 -06:00
test_webclient.py sort imports with isort 2023-01-25 14:25:15 -06:00
upper-constraints.txt upper-constraints.txt: restrict botocore further 2021-03-18 23:42:29 +01:00