diff --git a/Python-3-Porting.md b/Python-3-Porting.md index 26716b1..53d9c2e 100644 --- a/Python-3-Porting.md +++ b/Python-3-Porting.md @@ -14,4 +14,4 @@ When porting, please try follow these rules: * Don't rely only on existing tests to make the port; Scrapy test coverage is good but not perfect. Even if tests are passing don't consider a related module ported - please don't uncomment it from py3-ignores.txt without carefully reading the source code of a tested module and a source code of the test itself. Porting a module to Python 3 often require writing extra tests. * Try make sure your pull requests are focused and don't contain unrelated changes. If you've ported several modules it is better to make several pull requests. Reviewing Python 3 porting changes is hard because we can't rely only on tests - one have to check all the related modules; it is much easier to review and merge a small pull request. * It is OK not to port deprecated Scrapy features to Python 3 and skip the related tests for Python 3. -* It is OK to make a feature optional if it depends on a part of Twisted which is not ported yet. Of course, contributing to Twisted is welcome. See also: * [[PY3: Twisted Dependencies]]. \ No newline at end of file +* It is OK to make a feature optional if it depends on a part of Twisted which is not ported yet. Of course, contributing to Twisted is welcome. See also: [[PY3: Twisted Dependencies]]. \ No newline at end of file