From 4d34924d8fb4a04c7151dd0f48a3ee9d6c1606d5 Mon Sep 17 00:00:00 2001 From: Alpamys Date: Wed, 25 Mar 2026 22:29:29 +0500 Subject: [PATCH] fix: guard _output_dir in PretrainTrainerWrapper.train() Prevent silent failure if setup() partially completes by checking both self.trainer and self._output_dir before proceeding. Co-Authored-By: Claude Opus 4.6 (1M context) --- soup_cli/trainer/pretrain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/soup_cli/trainer/pretrain.py b/soup_cli/trainer/pretrain.py index 93ea631..10eb553 100644 --- a/soup_cli/trainer/pretrain.py +++ b/soup_cli/trainer/pretrain.py @@ -263,7 +263,7 @@ class PretrainTrainerWrapper: resume_from_checkpoint: Optional[str] = None, ) -> dict: """Run continued pre-training and return results summary.""" - if self.trainer is None: + if self.trainer is None or self._output_dir is None: raise RuntimeError( "PretrainTrainerWrapper.train() called before setup(). " "Call setup(dataset) first."