From 40bae8d73d311d8c8601be53670e83ca3c53bb2f Mon Sep 17 00:00:00 2001 From: Mason James Date: Thu, 27 Mar 2025 19:36:32 -0400 Subject: [PATCH] Fix URL params in embed player When opening/closing embedded videos, maintain existing URL parameters including pagination state. Previously, the video player would reset page to 0 and lose other query parameters. --- frontend/src/components/EmbeddableVideoPlayer.tsx | 6 +++++- frontend/src/components/VideoListItem.tsx | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/EmbeddableVideoPlayer.tsx b/frontend/src/components/EmbeddableVideoPlayer.tsx index 6ad0a791..e0a52583 100644 --- a/frontend/src/components/EmbeddableVideoPlayer.tsx +++ b/frontend/src/components/EmbeddableVideoPlayer.tsx @@ -121,7 +121,11 @@ const EmbeddableVideoPlayer = ({ videoId }: EmbeddableVideoPlayerProps) => { alt="close-icon" title="Close player" onClick={() => { - setSearchParams({}); + setSearchParams(params => { + const newParams = new URLSearchParams(params); + newParams.delete('videoId'); + return newParams; + }); }} /> diff --git a/frontend/src/components/VideoListItem.tsx b/frontend/src/components/VideoListItem.tsx index be0d45a8..368bc601 100644 --- a/frontend/src/components/VideoListItem.tsx +++ b/frontend/src/components/VideoListItem.tsx @@ -40,7 +40,11 @@ const VideoListItem = ({
{ - setSearchParams({ videoId: video.youtube_id }); + setSearchParams(params => { + const newParams = new URLSearchParams(params); + newParams.set('videoId', video.youtube_id); + return newParams; + }); }} >