From 49b7ecfb88d2d2bb53fbba82b73a35050cf5166c Mon Sep 17 00:00:00 2001
From: Craig Alexander <craig.d.alexander@gmail.com>
Date: Sun, 15 Jun 2025 00:50:23 -0400
Subject: [PATCH] Inspect apprise logs to get errors

---
 backend/task/views.py | 112 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 100 insertions(+), 12 deletions(-)

diff --git a/backend/task/views.py b/backend/task/views.py
index d6709b2e..6ca0414e 100644
--- a/backend/task/views.py
+++ b/backend/task/views.py
@@ -360,6 +360,63 @@ class NotificationTestView(ApiBaseView):
             ),
         },
     )
+    def _setup_apprise_logging(self):
+        """Setup logging capture for apprise"""
+        import io
+        import logging
+
+        log_capture = io.StringIO()
+        handler = logging.StreamHandler(log_capture)
+        formatter = logging.Formatter("%(levelname)s: %(message)s")
+        handler.setFormatter(formatter)
+        loggers_to_capture = ["apprise", "requests", "urllib3"]
+        original_levels = {}
+
+        for logger_name in loggers_to_capture:
+            logger = logging.getLogger(logger_name)
+            original_levels[logger_name] = logger.level
+            logger.addHandler(handler)
+            logger.setLevel(logging.DEBUG)
+            logger.propagate = True
+
+        return log_capture, handler, loggers_to_capture, original_levels
+
+    def _cleanup_apprise_logging(
+        self, handler, loggers_to_capture, original_levels
+    ):
+        """Cleanup apprise logging setup"""
+        import logging
+
+        for logger_name in loggers_to_capture:
+            logger = logging.getLogger(logger_name)
+            logger.removeHandler(handler)
+            logger.setLevel(original_levels[logger_name])
+
+    def _parse_apprise_error_message(self, log_output):
+        """Parse log output from apprise for detailed error information"""
+        error_msg = "Notification failed"
+        if log_output:
+            lines = log_output.strip().split("\n")
+            error_lines = [
+                line
+                for line in lines
+                if any(
+                    level in line for level in ["ERROR", "WARNING", "CRITICAL"]
+                )
+            ]
+            if error_lines:
+                error_msg = error_lines[-1]
+                if ":" in error_msg:
+                    error_msg = error_msg.split(":", 1)[-1].strip()
+            else:
+                error_msg = f"Notification failed - {log_output.strip()}"
+        else:
+            error_msg = (
+                "Notification failed - check URL format, "
+                "credentials, and network connectivity"
+            )
+        return error_msg
+
     def post(self, request):
         """test notification"""
         import apprise
@@ -371,21 +428,52 @@ class NotificationTestView(ApiBaseView):
         url = validated_data["url"]
         task_name = validated_data.get("task_name", "manual_test")
 
-        apobj = apprise.Apprise()
-        if not apobj.add(url):
-            error = ErrorResponseSerializer(
-                {"error": "invalid notification URL"}
-            )
-            return Response(error.data, status=400)
-
-        title = f"[TA] {task_name} process ended with SUCCESS"
-        body = "This is a test notification. Task completed successfully."
+        # Setup logging
+        log_capture, handler, loggers_to_capture, original_levels = (
+            self._setup_apprise_logging()
+        )
 
         try:
+            apobj = apprise.Apprise()
+
+            if not apobj.add(url):
+                log_output = log_capture.getvalue()
+                error_msg = f"Invalid notification URL format: {url}"
+                if log_output:
+                    error_msg += f" - Details: {log_output.strip()}"
+                return Response(
+                    {"success": False, "message": error_msg}, status=400
+                )
+
+            title = f"[TA] {task_name} process ended with SUCCESS"
+            body = "This is a test notification. Task completed successfully."
+
             result = apobj.notify(body=body, title=title)
+            log_output = log_capture.getvalue()
+
+            if result:
+                response_data = {
+                    "success": True,
+                    "message": "Test notification sent successfully",
+                }
+                if log_output:
+                    response_data["debug_info"] = log_output.strip()
+                return Response(response_data)
+
+            error_msg = self._parse_apprise_error_message(log_output)
             return Response(
-                {"success": result, "message": "Test notification sent"}
+                {"success": False, "message": error_msg}, status=400
             )
+
         except Exception as err:
-            error = ErrorResponseSerializer({"error": str(err)})
-            return Response(error.data, status=400)
+            log_output = log_capture.getvalue()
+            error_msg = f"Notification error: {str(err)}"
+            if log_output:
+                error_msg += f" - Log output: {log_output.strip()}"
+            return Response(
+                {"success": False, "message": error_msg}, status=400
+            )
+        finally:
+            self._cleanup_apprise_logging(
+                handler, loggers_to_capture, original_levels
+            )