diff --git a/backend/appsettings/serializers.py b/backend/appsettings/serializers.py index 734b3131..a319a08f 100644 --- a/backend/appsettings/serializers.py +++ b/backend/appsettings/serializers.py @@ -44,7 +44,6 @@ class AppConfigDownloadsSerializer( format = serializers.CharField(allow_null=True) format_sort = serializers.CharField(allow_null=True) add_metadata = serializers.BooleanField() - add_thumbnail = serializers.BooleanField() subtitle = serializers.CharField(allow_null=True) subtitle_source = serializers.ChoiceField( choices=["auto", "user"], allow_null=True diff --git a/backend/appsettings/src/config.py b/backend/appsettings/src/config.py index 2fb9247a..33983fa5 100644 --- a/backend/appsettings/src/config.py +++ b/backend/appsettings/src/config.py @@ -35,7 +35,6 @@ class DownloadsConfigType(TypedDict): format: str | None format_sort: str | None add_metadata: bool - add_thumbnail: bool subtitle: str | None subtitle_source: Literal["user", "auto"] | None subtitle_index: bool @@ -85,7 +84,6 @@ class AppConfig: "format": None, "format_sort": None, "add_metadata": False, - "add_thumbnail": False, "subtitle": None, "subtitle_source": None, "subtitle_index": False, diff --git a/backend/download/src/yt_dlp_handler.py b/backend/download/src/yt_dlp_handler.py index 9459ea3b..8aaf0234 100644 --- a/backend/download/src/yt_dlp_handler.py +++ b/backend/download/src/yt_dlp_handler.py @@ -482,10 +482,7 @@ class DownloadPostProcess(DownloaderBase): def embed_metadata(self): """embed metadata in media file""" - meta = self.config["downloads"].get("add_metadata") - thumb = self.config["downloads"].get("add_thumbnail") - - if not meta and not thumb: + if not self.config["downloads"].get("add_metadata"): return queue = RedisQueue(self.VIDEO_QUEUE) diff --git a/backend/video/src/index.py b/backend/video/src/index.py index e039aaa8..5fda13bd 100644 --- a/backend/video/src/index.py +++ b/backend/video/src/index.py @@ -433,8 +433,6 @@ class YoutubeVideo(YouTubeItem, YoutubeSubtitle): if self.config["downloads"].get("add_metadata"): self._embed_text_data() - - if self.config["downloads"].get("add_thumbnail"): self._embed_artwork() def _embed_text_data(self): diff --git a/frontend/src/api/loader/loadAppsettingsConfig.ts b/frontend/src/api/loader/loadAppsettingsConfig.ts index 19091533..1d74689e 100644 --- a/frontend/src/api/loader/loadAppsettingsConfig.ts +++ b/frontend/src/api/loader/loadAppsettingsConfig.ts @@ -16,7 +16,6 @@ export type AppSettingsConfigType = { format: string | null; format_sort: string | null; add_metadata: boolean; - add_thumbnail: boolean; subtitle: string | null; subtitle_source: string | null; subtitle_index: boolean; diff --git a/frontend/src/pages/Home.tsx b/frontend/src/pages/Home.tsx index d01a96d4..09ac57f9 100644 --- a/frontend/src/pages/Home.tsx +++ b/frontend/src/pages/Home.tsx @@ -89,7 +89,6 @@ export type DownloadsType = { format: boolean; format_sort: boolean; add_metadata: boolean; - add_thumbnail: boolean; subtitle: boolean; subtitle_source: boolean; subtitle_index: boolean; diff --git a/frontend/src/pages/SettingsApplication.tsx b/frontend/src/pages/SettingsApplication.tsx index 755e0eaa..c59fde46 100644 --- a/frontend/src/pages/SettingsApplication.tsx +++ b/frontend/src/pages/SettingsApplication.tsx @@ -58,7 +58,6 @@ const SettingsApplication = () => { const [downloadsFormatSort, setDownloadsFormatSort] = useState(null); const [downloadsExtractorLang, setDownloadsExtractorLang] = useState(null); const [embedMetadata, setEmbedMetadata] = useState(false); - const [embedThumbnail, setEmbedThumbnail] = useState(false); // Subtitles const [subtitleLang, setSubtitleLang] = useState(null); @@ -116,7 +115,6 @@ const SettingsApplication = () => { setDownloadsFormatSort(appSettingsConfigData?.downloads.format_sort || null); setDownloadsExtractorLang(appSettingsConfigData?.downloads.extractor_lang || null); setEmbedMetadata(appSettingsConfigData?.downloads.add_metadata || false); - setEmbedThumbnail(appSettingsConfigData?.downloads.add_thumbnail || false); // Subtitles setSubtitleLang(appSettingsConfigData?.downloads.subtitle || null); @@ -476,9 +474,8 @@ const SettingsApplication = () => { -
  • Embedding metadata adds additional metadata directly to the mp4 file.
  • - Embedding the thumbnail embeds the video thumbnail as a cover.jpg to the mp4 + Embedding metadata adds additional metadata and thumbnails directly to the mp4 file.
  • @@ -533,16 +530,6 @@ const SettingsApplication = () => { updateCallback={handleUpdateConfig} /> -
    -
    -

    Embed Thumbnail

    -
    - -

    Subtitles

    diff --git a/frontend/src/stores/AppSettingsStore.ts b/frontend/src/stores/AppSettingsStore.ts index 844285e5..80eb43f8 100644 --- a/frontend/src/stores/AppSettingsStore.ts +++ b/frontend/src/stores/AppSettingsStore.ts @@ -23,7 +23,6 @@ export const useAppSettingsStore = create(set => ({ format: null, format_sort: null, add_metadata: false, - add_thumbnail: false, subtitle: null, subtitle_source: null, subtitle_index: false,