From 7807152cdf3da11f634234963e47d8f1018f5931 Mon Sep 17 00:00:00 2001 From: Caleb Rogers Date: Thu, 18 Jun 2026 12:18:25 +0200 Subject: [PATCH] Don't setState in useEffect --- frontend/src/components/EmbeddableVideoPlayer.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/EmbeddableVideoPlayer.tsx b/frontend/src/components/EmbeddableVideoPlayer.tsx index b4201038..69f4291d 100644 --- a/frontend/src/components/EmbeddableVideoPlayer.tsx +++ b/frontend/src/components/EmbeddableVideoPlayer.tsx @@ -37,12 +37,14 @@ const EmbeddableVideoPlayer = ({ videoId }: EmbeddableVideoPlayerProps) => { const { data: videoResponseData } = videoResponse ?? {}; - useEffect(() => { + const [prevVideoId, setPrevVideoId] = useState(videoId); + if (videoId !== prevVideoId) { + setPrevVideoId(videoId); if (!videoId) { setVideoResponse(undefined); setPlaylists(undefined); } - }, [videoId]); + } useEffect(() => { (async () => {