From 332cd24dfc5638feb03bb12111648e87737829fd Mon Sep 17 00:00:00 2001
From: JovannMC <jovannmc@femboyfurry.net>
Date: Sun, 1 Jun 2025 23:57:23 +0300
Subject: [PATCH] fix: don't show gifs in video category

---
 .../functional/FormatDropdown.svelte          | 31 ++++++++++++++-----
 src/routes/convert/+page.svelte               |  1 +
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/src/lib/components/functional/FormatDropdown.svelte b/src/lib/components/functional/FormatDropdown.svelte
index 08ba789..4937645 100644
--- a/src/lib/components/functional/FormatDropdown.svelte
+++ b/src/lib/components/functional/FormatDropdown.svelte
@@ -8,6 +8,7 @@
 
 	type Props = {
 		categories: Categories;
+		from?: string;
 		selected?: string;
 		onselect?: (option: string) => void;
 		disabled?: boolean;
@@ -15,6 +16,7 @@
 
 	let {
 		categories,
+		from,
 		selected = $bindable(""),
 		onselect,
 		disabled,
@@ -59,6 +61,15 @@
 		);
 	});
 
+	const shouldInclude = (format: string, category: string): boolean => {
+		// if converting from audio to video, dont show gifs
+		if (categories["audio"]?.formats.includes(from ?? "") && format === ".gif") {
+			return false;
+		}
+
+		return true;
+	};
+
 	const filteredData = $derived.by(() => {
 		const normalize = (str: string) => str.replace(/^\./, "").toLowerCase();
 
@@ -67,7 +78,9 @@
 			return {
 				categories: availableCategories,
 				formats: currentCategory
-					? categories[currentCategory].formats
+					? categories[currentCategory].formats.filter((format) =>
+							shouldInclude(format, currentCategory!),
+						)
 					: [],
 			};
 		}
@@ -75,8 +88,10 @@
 
 		// find all categories that have formats matching the search query
 		const matchingCategories = availableCategories.filter((cat) =>
-			categories[cat].formats.some((format) =>
-				normalize(format).includes(searchLower),
+			categories[cat].formats.some(
+				(format) =>
+					normalize(format).includes(searchLower) &&
+					shouldInclude(format, cat),
 			),
 		);
 		if (matchingCategories.length === 0) {
@@ -89,9 +104,7 @@
 		// if current category has no matches, switch to first category that does
 		const currentCategoryHasMatches =
 			currentCategory &&
-			matchingCategories.some(
-				(cat) => cat === currentCategory,
-			);
+			matchingCategories.some((cat) => cat === currentCategory);
 		if (!currentCategoryHasMatches && matchingCategories.length > 0) {
 			const newCategory = matchingCategories[0];
 			currentCategory = newCategory;
@@ -99,8 +112,10 @@
 
 		// return formats only from the current category that match the search
 		let filteredFormats = currentCategory
-			? categories[currentCategory].formats.filter((format) =>
-					normalize(format).includes(searchLower),
+			? categories[currentCategory].formats.filter(
+					(format) =>
+						normalize(format).includes(searchLower) &&
+						shouldInclude(format, currentCategory!),
 				)
 			: [];
 
diff --git a/src/routes/convert/+page.svelte b/src/routes/convert/+page.svelte
index a31cbd4..747b373 100644
--- a/src/routes/convert/+page.svelte
+++ b/src/routes/convert/+page.svelte
@@ -267,6 +267,7 @@
 					>
 						<FormatDropdown
 							{categories}
+							from={file.from}
 							bind:selected={file.to}
 							onselect={(option) => handleSelect(option, file)}
 						/>