From 816257a1d6705c131ba5b3fe72f77306069db7c7 Mon Sep 17 00:00:00 2001 From: Mailo Date: Mon, 24 Nov 2025 16:58:18 +0100 Subject: [PATCH] Clarify ICO size clamping comment and align error variable naming. --- src/lib/workers/magick.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/workers/magick.ts b/src/lib/workers/magick.ts index 9d77b79..aa3ab5d 100644 --- a/src/lib/workers/magick.ts +++ b/src/lib/workers/magick.ts @@ -293,7 +293,7 @@ const magickConvert = async ( let fmt = to.slice(1).toUpperCase(); if (fmt === "JFIF") fmt = "JPEG"; - // ✅ ICO size clamp to avoid WidthOrHeightExceedsLimit + // ICO size clamp to avoid WidthOrHeightExceedsLimit if (fmt === "ICO") { const max = 256; const w = img.width; @@ -310,14 +310,15 @@ const magickConvert = async ( const result = await new Promise((resolve, reject) => { try { + // magick-wasm automatically clamps (https://github.com/dlemstra/magick-wasm/blob/76fc6f2b0c0497d2ddc251bbf6174b4dc92ac3ea/src/magick-image.ts#L2480) if (compression) img.quality = compression; if (!keepMetadata) img.strip(); img.write(fmt as unknown as MagickFormat, (o: Uint8Array) => { resolve(structuredClone(o)); }); - } catch (e) { - reject(e); + } catch (error) { + reject(error); } });