From b0cc5b6d8a2a733541b867393c857343a1360dd1 Mon Sep 17 00:00:00 2001
From: Maya <jovannmc@femboyfurry.net>
Date: Tue, 2 Sep 2025 22:01:23 +0800
Subject: [PATCH] fix: null quality option

oopsies, also actually shows custom sample rate in console
---
 src/lib/converters/ffmpeg.svelte.ts | 12 ++++++------
 src/lib/converters/magick.svelte.ts |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/lib/converters/ffmpeg.svelte.ts b/src/lib/converters/ffmpeg.svelte.ts
index 2090753..e9ccebc 100644
--- a/src/lib/converters/ffmpeg.svelte.ts
+++ b/src/lib/converters/ffmpeg.svelte.ts
@@ -319,14 +319,14 @@ export class FFmpegConverter extends Converter {
 
 		// sample rate setting
 		if (userSampleRate !== "auto") {
-			if (userSampleRate === "custom") {
-				sampleRateArgs = ["-ar", customSampleRate.toString()];
-			} else {
-				sampleRateArgs = ["-ar", userSampleRate];
-			}
+			const rate =
+				userSampleRate === "custom"
+					? customSampleRate.toString()
+					: userSampleRate;
+			sampleRateArgs = ["-ar", rate];
 			log(
 				["converters", this.name],
-				`using user setting for sample rate: ${userSampleRate}`,
+				`using user setting for sample rate: ${rate}`,
 			);
 		} else {
 			// detect sample rate of original file and use
diff --git a/src/lib/converters/magick.svelte.ts b/src/lib/converters/magick.svelte.ts
index fbdfd9c..2183915 100644
--- a/src/lib/converters/magick.svelte.ts
+++ b/src/lib/converters/magick.svelte.ts
@@ -110,8 +110,8 @@ export class MagickConverter extends Converter {
 		...args: any[]
 	): Promise<VertFile> {
 		let compression: number | undefined = args.at(0);
-		if (compression == null) {
-			compression = Settings.instance.settings.magickQuality;
+		if (!compression) {
+			compression = Settings.instance.settings.magickQuality ?? 100;
 			log(["converters", this.name], `using user setting for quality: ${compression}%`);
 		}
 		log(["converters", this.name], `converting ${input.name} to ${to}`);